[Bug 2353869] Review Request: libmbd - Many-body dispersion library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2353869

Cristian Le <fedora@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(benson_muite@emai
                   |                            |lplus.org)



--- Comment #15 from Cristian Le <fedora@xxxxxxxxx> ---
> a) What prevents building python versions other than licensing of data file?

Mostly time to work on it and need to have it. They are using their own custom
build framework [1] and I want to make sure we are doing it right. I need to
discuss with upstream if they would want to use more conventional build
backends (biased towards scikit-build-core because it's a CMake project). If
you want, I will ping you for a re-review of the python components when I am
working on it, but it should look like the current one other than fixing the
paths to point to build-time artifacts and fixing the rpaths. If I can convince
them to go with scikit-build-core, well, it will look like spglib's approach.

> b) Small typo

I will fix that on import or the next build, thanks for catching it

[1]: https://github.com/libmbd/libmbd/blob/master/build.py


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2353869

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353869%23c15

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux