https://bugzilla.redhat.com/show_bug.cgi?id=2314358 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|ASSIGNED |POST --- Comment #29 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > %bcond boot 1 Please consider renaming to 'bootstrap'. 'bootstrap' is special, it's one of the macros allowlisted in koji policy. (Also "boot" sounds too much like "machine boot", which I know comes from the same root, but nowadays is used almost exclusively in the short form for that purpose.) > %package lib Please consider renaming to -libs. '-libs' is much more popular and is used even by packages which have just a single library: $ rpm -qa|grep -e '-lib\b'|wc -l; rpm -qa|grep -e '-libs\b'|wc -l 16 254 I checked that the compiled programs runs fine with only -lib installed, and doesn't when that package is removed. So the split seems correct. All the comments from the previous round have been addressed and I don't see any new issues. Package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2314358 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314358%23c29 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
