https://bugzilla.redhat.com/show_bug.cgi?id=2369466 --- Comment #21 from Jarek Prokop <jprokop@xxxxxxxxxx> --- So far the biggest problem is that scratch-build in Fedora Koji fails: It seems that the current state is: macro fails, the %if further down only has that macro, if it is undefined in this case, the build fails. > https://koji.fedoraproject.org/koji/taskinfo?taskID=134584043 mock_output.log ~~~ sh: line 1: hexdump: command not found error: unexpected end of expression: error: ^ error: /chroot_tmpdir/srpm_unpacked/SPECS/nodejs24.spec:400: bad %if condition: ~~~ 2 notes for this: ~~~ BuildRequires: %{_bindir}/hexdump BuildRequires: %{_bindir}/awk BuildRequires: %{_bindir}/grep ~~~ should prevent this. I have used that approach here: https://koji.fedoraproject.org/koji/taskinfo?taskID=134584200 and the following in tandem: Prepending 0 to prevent syntactical errors when it fails: ~~~ %if 0%{little_endian} ~~~ And lastly, the echo uses `-N`, seems the intent was `-n`?: ~~~ %global little_endian %(echo -n I|hexdump -o|awk '{print substr($2,6,1); exit}') ~~~ otherwise the echo echoes out too much. Though currently I am wondering whether we could grab the 1 or 0 from lua with some magic... https://koji.fedoraproject.org/koji/taskinfo?taskID=134584199 failed on ppc64le and i686, the ppc64le seem to be around some builtin SIMD ppc functions: `__builtin_vsx_xvcvspuxds`, or maybe something with ICU data maybe. Package not building in koji is currently the main stop. > License: Having enumerated which files have which license would be nice-to-have. > Macro consistency Openssl has a version requirement in macro so it is later used as `pkgconfig(openssl) >= %{openssl_minimal_version}` while compilers use explicit versions: `BuildRequires: gcc >= 10.0, gcc-c++ >= 10.0, pkgconf, ninja-build` %{gcc_minimal_version} could be defined together with the openssl's minimal version. > v8 vs v8-devel If we have nodejs-libs as providing v8, why is there a separation of nodejs-devel and v8-devel? Furthermore, %install seems to establish symlinks for v8 and v8-devel as well if I'm reading that section correctly, so v8-devel could probably be a part of nodejs-devel -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2369466 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202369466%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
