https://bugzilla.redhat.com/show_bug.cgi?id=2375027 --- Comment #1 from Carl George 🤠 <carl@xxxxxxxxxx> --- The provides and obsoletes need to reference the current binary package name python3-ramalama, not the source package name python-ramalama. Also the obsoletes shouldn't use the version and release macros, but rather use a release one higher than the last shipped release (which is currently 0.9.3-1). -Provides: python-ramalama = %{version}-%{release} -Obsoletes: python-ramalama < %{version}-%{release} +Provides: python3-ramalama = %{version}-%{release} +Obsoletes: python3-ramalama < 0.9.3-2 https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages ================================================================================ The build requirements need some adjustments. It isn't necessary to manually specify python3 or pyproject-rpm-macros because these are pulled in by python3-devel. Dependencies covered by the generators should not be repeated. The python3_pkgversion macros are unnecessary and can be dropped for improved readability. The minimum version of Python is covered by the upstream metadata, and doesn't need to be repeated in the spec file. -BuildRequires: pyproject-rpm-macros -BuildRequires: python3 >= 3.11 -BuildRequires: python%{python3_pkgversion}-argcomplete -BuildRequires: python%{python3_pkgversion}-devel -BuildRequires: python%{python3_pkgversion}-pip -BuildRequires: python%{python3_pkgversion}-setuptools -BuildRequires: python%{python3_pkgversion}-wheel +BuildRequires: python3-devel https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies ================================================================================ The files header defaults to the top level package name, so there is no need to pass it as an option. -%files -n %{pypi_name} -f %{pyproject_files} +%files -f %{pyproject_files} ================================================================================ This package places files in /usr/libexec/ramalama, but doesn't own that directory. -%{_libexecdir}/ramalama/* +%{_libexecdir}/ramalama https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ ================================================================================ The fish and zsh completion paths must use the corresponding *_completions_dir macros instead of hardcoded paths. For zsh it will also need some adjustments to the source code, either by patch or sed, because currently it is installing it to a different directory than that macro references. -%{_datadir}/fish/vendor_completions.d/ramalama.fish -%{_datadir}/zsh/vendor-completions/_ramalama +%{fish_completions_dir}/ramalama.fish +%{zsh_completions_dir}/_ramalama https://docs.fedoraproject.org/en-US/packaging-guidelines/ShellCompletions/ ================================================================================ The upstream unit tests should be run. It looks like they work in mock as long as podman is available. You can still run the import check if you want, but it's not necessary if the unit tests are being run as that will catch any import problems. +BuildRequires: podman %check -%pyproject_check_import +%pytest -v test/unit https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests ================================================================================ There are some rpmlint errors that should be easy enough to clear. ramalama.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/ramalama/chat.py 644 /usr/bin/env python3 This can be avoided by removing that shebang line with patch or sed. ramalama.noarch: W: name-repeated-in-summary RamaLama -%global summary RamaLama is a command line tool for working with AI LLM models +%global summary Command line tool for working with AI LLM models ramalama.noarch: W: files-duplicate /usr/share/zsh/vendor-completions/_ramalama /usr/share/bash-completion/completions/ramalama It seems these files are identical in the upstream source. Is it possible to have a completion file that works in both bash and zsh, or is this a bug? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2375027 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202375027%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
