https://bugzilla.redhat.com/show_bug.cgi?id=2258041 andreyesquivel.dev@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreyesquivel.dev@proton.m | |e --- Comment #5 from andreyesquivel.dev@xxxxxxxxx --- Hello team, This is a mock review for the Fedora sponsorship process. During the rpmlint test on the spec file, a warning was found indicating the absence of a %check section: W: no-%check-section To investigate this, I examined the Makefile and the source code files included in the tarball. The Makefile does not include any target or commands related to running automated tests, and there are no separate test scripts or test directories in the source archive. It would be appropriate to add a %check section with a comment after installing (see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_scriptlets) explaining that no tests are available, which would silence the rpmlint warning and clarify this point for future maintainers. Suggested addition: %check # No upstream tests available Additionally, rpmlint on the built RPM returned the following output: pam_xdg_runtime_dir.x86_64: E: spelling-error ('uid', 'Summary(en_US) uid -> yid, id, aid') pam_xdg_runtime_dir.x86_64: E: spelling-error ('systemd', '%description -l en_US systemd -> systems, system, system d') pam_xdg_runtime_dir.x86_64: E: spelling-error ('logind', '%description -l en_US logind -> logins, login, log ind') pam_xdg_runtime_dir.x86_64: E: spelling-error ('uid', '%description -l en_US uid -> yid, id, aid') pam_xdg_runtime_dir.x86_64: E: pam-unauthorized-module pam_xdg_runtime_dir.so Regarding the spelling errors, these warnings occur because rpmlint uses an English dictionary that does not recognize specific Linux-related keywords. These can safely be ignored in this context. Finally, the pam-unauthorized-module error reflects Fedora policy around security-sensitive components. Please contact the appropriate Fedora team for review. (see https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/). Please let me know if further clarifications or revisions are needed. I hope this may be helpful for future maintainers. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2258041 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258041%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
