https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Tomas Hrcka <thrcka@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |MODIFIED --- Comment #80 from Tomas Hrcka <thrcka@xxxxxxxxxx> --- ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. </snip the license string because of BZ coomment lenght limitations, content is the same as previous run> [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config(noreplace,missingok) /etc/sysconfig/forgejo [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 406521 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in forgejo [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3502080 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: forgejo-11.0.2-1.fc43.x86_64.rpm forgejo-11.0.2-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2bft4mdu')] checks: 32, packages: 2 forgejo.src: E: spelling-error ('forˈd͡ʒe', '%description -l en_US forˈd͡ʒe -> foreword') forgejo.x86_64: E: spelling-error ('forˈd͡ʒe', '%description -l en_US forˈd͡ʒe -> foreword') forgejo.spec: W: patch-not-applied Patch0: forgejo-10.0.1-app.ini.tmpl.patch forgejo.x86_64: W: non-standard-uid /var/lib/forgejo forgejo forgejo.x86_64: W: non-standard-uid /var/lib/forgejo/data forgejo forgejo.x86_64: W: non-standard-uid /var/lib/forgejo/log forgejo forgejo.x86_64: W: non-standard-gid /etc/forgejo/conf/app.ini forgejo forgejo.x86_64: W: non-standard-gid /var/lib/forgejo forgejo forgejo.x86_64: W: non-standard-gid /var/lib/forgejo/data forgejo forgejo.x86_64: W: non-standard-gid /var/lib/forgejo/log forgejo forgejo.x86_64: E: non-standard-dir-perm /var/lib/forgejo 750 forgejo.x86_64: E: non-standard-dir-perm /var/lib/forgejo/data 750 forgejo.x86_64: E: non-standard-dir-perm /var/lib/forgejo/log 750 forgejo.x86_64: E: non-readable /etc/sysconfig/forgejo 640 forgejo.x86_64: W: non-conffile-in-etc /etc/forgejo/conf/app.ini.tmpl forgejo.x86_64: W: no-manual-page-for-binary forgejo forgejo.spec: W: invalid-url Source2: forgejo-11.0.2-nodejs-vendor.tar.xz forgejo.spec: W: invalid-url Source1: forgejo-11.0.2-go-vendor.tar.bz2 forgejo.x86_64: W: empty-%pre forgejo.x86_64: W: cross-directory-hard-link /usr/share/licenses/forgejo/vendor/code.forgejo.org/go-chi/cache/LICENSE /usr/share/licenses/forgejo/vendor/code.forgejo.org/go-chi/binding/LICENSE </snip there is another 300+ warning with similar content, this is the result of hardlinking the licences, cutting it out because of BZ coomment lenght limitations> 2 packages and 0 specfiles checked; 6 errors, 374 warnings, 7 filtered, 6 badness; has taken 3.8 s Rpmlint (debuginfo) ------------------- Checking: forgejo-debuginfo-11.0.2-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpb0nxroo1')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 2.3 s Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 forgejo.x86_64: W: unused-direct-shlib-dependency /usr/bin/forgejo /lib64/libresolv.so.2 forgejo.x86_64: E: spelling-error ('forˈd͡ʒe', '%description -l en_US forˈd͡ʒe -> foreword') forgejo.x86_64: W: non-standard-uid /var/lib/forgejo forgejo forgejo.x86_64: W: non-standard-uid /var/lib/forgejo/data forgejo forgejo.x86_64: W: non-standard-uid /var/lib/forgejo/log forgejo forgejo.x86_64: W: non-standard-gid /etc/forgejo/conf/app.ini forgejo forgejo.x86_64: W: non-standard-gid /var/lib/forgejo forgejo forgejo.x86_64: W: non-standard-gid /var/lib/forgejo/data forgejo forgejo.x86_64: W: non-standard-gid /var/lib/forgejo/log forgejo forgejo.x86_64: E: non-standard-dir-perm /var/lib/forgejo 750 forgejo.x86_64: E: non-standard-dir-perm /var/lib/forgejo/data 750 forgejo.x86_64: E: non-standard-dir-perm /var/lib/forgejo/log 750 forgejo.x86_64: E: non-readable /etc/sysconfig/forgejo 640 forgejo.x86_64: W: non-conffile-in-etc /etc/forgejo/conf/app.ini.tmpl forgejo.x86_64: W: no-manual-page-for-binary forgejo forgejo.x86_64: W: empty-%pre forgejo.x86_64: W: cross-directory-hard-link /usr/share/licenses/forgejo/vendor/code.forgejo.org/go-chi/cache/LICENSE /usr/share/licenses/forgejo/vendor/code.forgejo.org/go-chi/binding/LICENSE forgejo.x86_64: W: cross-directory-hard-link /usr/share/licenses/forgejo/vendor/gopkg.in/ini.v1/LICENSE /usr/share/licenses/forgejo/vendor/github.com/go-ini/ini/LICENSE </snip there is another 300+ warning with similar content, this is the result of hardlinking the licences, cutting it out because of BZ coomment lenght limitations> 2 packages and 0 specfiles checked; 5 errors, 372 warnings, 9 filtered, 5 badness; has taken 0.7 s Source checksums ---------------- https://codeberg.org/forgejo/forgejo/archive/v11.0.2.tar.gz#/forgejo-11.0.2.tar.gz : CHECKSUM(SHA256) this package : d9e73f14908491f98ebf97203dd716c80e0866b39f3964ce7a7c909b45364749 CHECKSUM(SHA256) upstream package : d9e73f14908491f98ebf97203dd716c80e0866b39f3964ce7a7c909b45364749 Requires -------- forgejo (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash bash config(forgejo) coreutils git-core git-lfs group(forgejo) libc.so.6()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) sed user(forgejo) Provides -------- forgejo: bundled(golang(cloud.google.com/go/compute/metadata)) bundled(golang(code.forgejo.org/f3/gof3/v3)) bundled(golang(code.forgejo.org/forgejo-contrib/go-libravatar)) bundled(golang(code.forgejo.org/forgejo/act)) bundled(golang(code.forgejo.org/forgejo/archiver/v3)) bundled(golang(code.forgejo.org/forgejo/go-xsd-duration)) bundled(golang(code.forgejo.org/forgejo/levelqueue)) bundled(golang(code.forgejo.org/forgejo/reply)) bundled(golang(code.forgejo.org/forgejo/ssh)) bundled(golang(code.forgejo.org/go-chi/binding)) bundled(golang(code.forgejo.org/go-chi/cache)) bundled(golang(code.forgejo.org/go-chi/captcha)) bundled(golang(code.forgejo.org/go-chi/session)) bundled(golang(code.gitea.io/actions-proto-go)) bundled(golang(code.gitea.io/sdk/gitea)) bundled(golang(codeberg.org/gusted/mcaptcha)) bundled(golang(connectrpc.com/connect)) bundled(golang(dario.cat/mergo)) bundled(golang(filippo.io/edwards25519)) bundled(golang(github.com/42wim/httpsig)) bundled(golang(github.com/42wim/sshsig)) bundled(golang(github.com/6543/go-version)) bundled(golang(github.com/Azure/go-ntlmssp)) bundled(golang(github.com/DataDog/zstd)) bundled(golang(github.com/Microsoft/go-winio)) bundled(golang(github.com/ProtonMail/go-crypto)) bundled(golang(github.com/PuerkitoBio/goquery)) bundled(golang(github.com/RoaringBitmap/roaring/v2)) bundled(golang(github.com/SaveTheRbtz/zstd-seekable-format-go/pkg)) bundled(golang(github.com/alecthomas/chroma/v2)) bundled(golang(github.com/andybalholm/brotli)) bundled(golang(github.com/andybalholm/cascadia)) bundled(golang(github.com/anmitsu/go-shlex)) bundled(golang(github.com/aymerick/douceur)) bundled(golang(github.com/beorn7/perks)) bundled(golang(github.com/bits-and-blooms/bitset)) bundled(golang(github.com/blakesmith/ar)) bundled(golang(github.com/blevesearch/bleve/v2)) bundled(golang(github.com/blevesearch/bleve_index_api)) bundled(golang(github.com/blevesearch/geo)) bundled(golang(github.com/blevesearch/go-faiss)) bundled(golang(github.com/blevesearch/go-porterstemmer)) bundled(golang(github.com/blevesearch/gtreap)) bundled(golang(github.com/blevesearch/mmap-go)) bundled(golang(github.com/blevesearch/scorch_segment_api/v2)) bundled(golang(github.com/blevesearch/segment)) bundled(golang(github.com/blevesearch/snowballstem)) bundled(golang(github.com/blevesearch/upsidedown_store_api)) bundled(golang(github.com/blevesearch/vellum)) bundled(golang(github.com/blevesearch/zapx/v11)) bundled(golang(github.com/blevesearch/zapx/v12)) bundled(golang(github.com/blevesearch/zapx/v13)) bundled(golang(github.com/blevesearch/zapx/v14)) bundled(golang(github.com/blevesearch/zapx/v15)) bundled(golang(github.com/blevesearch/zapx/v16)) bundled(golang(github.com/boombuler/barcode)) bundled(golang(github.com/bradfitz/gomemcache)) bundled(golang(github.com/buildkite/terminal-to-html/v3)) bundled(golang(github.com/caddyserver/certmagic)) bundled(golang(github.com/caddyserver/zerossl)) bundled(golang(github.com/cention-sany/utf7)) bundled(golang(github.com/cespare/xxhash/v2)) bundled(golang(github.com/chi-middleware/proxy)) bundled(golang(github.com/cloudflare/circl)) bundled(golang(github.com/cpuguy83/go-md2man/v2)) bundled(golang(github.com/cyphar/filepath-securejoin)) bundled(golang(github.com/davecgh/go-spew)) bundled(golang(github.com/davidmz/go-pageant)) bundled(golang(github.com/dgryski/go-rendezvous)) bundled(golang(github.com/djherbis/buffer)) bundled(golang(github.com/djherbis/nio/v3)) bundled(golang(github.com/dlclark/regexp2)) bundled(golang(github.com/dsnet/compress)) bundled(golang(github.com/dustin/go-humanize)) bundled(golang(github.com/editorconfig/editorconfig-core-go/v2)) bundled(golang(github.com/emersion/go-imap)) bundled(golang(github.com/emersion/go-sasl)) bundled(golang(github.com/emirpasic/gods)) bundled(golang(github.com/fatih/color)) bundled(golang(github.com/felixge/fgprof)) bundled(golang(github.com/fsnotify/fsnotify)) bundled(golang(github.com/fxamacker/cbor/v2)) bundled(golang(github.com/go-ap/activitypub)) bundled(golang(github.com/go-ap/errors)) bundled(golang(github.com/go-ap/jsonld)) bundled(golang(github.com/go-asn1-ber/asn1-ber)) bundled(golang(github.com/go-chi/chi/v5)) bundled(golang(github.com/go-chi/cors)) bundled(golang(github.com/go-co-op/gocron)) bundled(golang(github.com/go-enry/go-enry/v2)) bundled(golang(github.com/go-enry/go-oniguruma)) bundled(golang(github.com/go-fed/httpsig)) bundled(golang(github.com/go-git/gcfg)) bundled(golang(github.com/go-git/go-billy/v5)) bundled(golang(github.com/go-git/go-git/v5)) bundled(golang(github.com/go-ini/ini)) bundled(golang(github.com/go-ldap/ldap/v3)) bundled(golang(github.com/go-openapi/jsonpointer)) bundled(golang(github.com/go-openapi/jsonreference)) bundled(golang(github.com/go-openapi/spec)) bundled(golang(github.com/go-openapi/swag)) bundled(golang(github.com/go-sql-driver/mysql)) bundled(golang(github.com/go-webauthn/webauthn)) bundled(golang(github.com/go-webauthn/x)) bundled(golang(github.com/gobwas/glob)) bundled(golang(github.com/goccy/go-json)) bundled(golang(github.com/gogs/chardet)) bundled(golang(github.com/gogs/go-gogs-client)) bundled(golang(github.com/golang-jwt/jwt/v4)) bundled(golang(github.com/golang-jwt/jwt/v5)) bundled(golang(github.com/golang/freetype)) bundled(golang(github.com/golang/groupcache)) bundled(golang(github.com/golang/protobuf)) bundled(golang(github.com/golang/snappy)) bundled(golang(github.com/google/btree)) bundled(golang(github.com/google/go-cmp)) bundled(golang(github.com/google/go-github/v64)) bundled(golang(github.com/google/go-querystring)) bundled(golang(github.com/google/go-tpm)) bundled(golang(github.com/google/pprof)) bundled(golang(github.com/google/uuid)) bundled(golang(github.com/gorilla/css)) bundled(golang(github.com/gorilla/feeds)) bundled(golang(github.com/gorilla/mux)) bundled(golang(github.com/gorilla/securecookie)) bundled(golang(github.com/gorilla/sessions)) bundled(golang(github.com/hashicorp/go-cleanhttp)) bundled(golang(github.com/hashicorp/go-retryablehttp)) bundled(golang(github.com/hashicorp/golang-lru/v2)) bundled(golang(github.com/huandu/xstrings)) bundled(golang(github.com/jaytaylor/html2text)) bundled(golang(github.com/jbenet/go-context)) bundled(golang(github.com/jhillyerd/enmime/v2)) bundled(golang(github.com/josharian/intern)) bundled(golang(github.com/json-iterator/go)) bundled(golang(github.com/kballard/go-shellquote)) bundled(golang(github.com/kevinburke/ssh_config)) bundled(golang(github.com/klauspost/compress)) bundled(golang(github.com/klauspost/cpuid/v2)) bundled(golang(github.com/klauspost/pgzip)) bundled(golang(github.com/lib/pq)) bundled(golang(github.com/libdns/libdns)) bundled(golang(github.com/lunny/vfsgen)) bundled(golang(github.com/mailru/easyjson)) bundled(golang(github.com/markbates/going)) bundled(golang(github.com/markbates/goth)) bundled(golang(github.com/mattn/go-colorable)) bundled(golang(github.com/mattn/go-isatty)) bundled(golang(github.com/mattn/go-runewidth)) bundled(golang(github.com/mattn/go-sqlite3)) bundled(golang(github.com/meilisearch/meilisearch-go)) bundled(golang(github.com/mholt/acmez/v3)) bundled(golang(github.com/microcosm-cc/bluemonday)) bundled(golang(github.com/miekg/dns)) bundled(golang(github.com/minio/crc64nvme)) bundled(golang(github.com/minio/md5-simd)) bundled(golang(github.com/minio/minio-go/v7)) bundled(golang(github.com/mitchellh/mapstructure)) bundled(golang(github.com/modern-go/concurrent)) bundled(golang(github.com/modern-go/reflect2)) bundled(golang(github.com/mrjones/oauth)) bundled(golang(github.com/mschoch/smat)) bundled(golang(github.com/msteinert/pam/v2)) bundled(golang(github.com/munnerz/goautoneg)) bundled(golang(github.com/niklasfasching/go-org)) bundled(golang(github.com/nwaples/rardecode)) bundled(golang(github.com/olekukonko/tablewriter)) bundled(golang(github.com/olivere/elastic/v7)) bundled(golang(github.com/onsi/ginkgo)) bundled(golang(github.com/opencontainers/go-digest)) bundled(golang(github.com/opencontainers/image-spec)) bundled(golang(github.com/pierrec/lz4/v4)) bundled(golang(github.com/pjbgf/sha1cd)) bundled(golang(github.com/pkg/errors)) bundled(golang(github.com/pmezard/go-difflib)) bundled(golang(github.com/pquerna/otp)) bundled(golang(github.com/prometheus/client_golang)) bundled(golang(github.com/prometheus/client_model)) bundled(golang(github.com/prometheus/common)) bundled(golang(github.com/prometheus/procfs)) bundled(golang(github.com/redis/go-redis/v9)) bundled(golang(github.com/rhysd/actionlint)) bundled(golang(github.com/rivo/uniseg)) bundled(golang(github.com/robfig/cron/v3)) bundled(golang(github.com/rogpeppe/go-internal)) bundled(golang(github.com/rs/xid)) bundled(golang(github.com/russross/blackfriday/v2)) bundled(golang(github.com/santhosh-tekuri/jsonschema/v6)) bundled(golang(github.com/sassoftware/go-rpmutils)) bundled(golang(github.com/sergi/go-diff)) bundled(golang(github.com/shurcooL/httpfs)) bundled(golang(github.com/sirupsen/logrus)) bundled(golang(github.com/skeema/knownhosts)) bundled(golang(github.com/ssor/bom)) bundled(golang(github.com/stretchr/testify)) bundled(golang(github.com/syndtr/goleveldb)) bundled(golang(github.com/ulikunitz/xz)) bundled(golang(github.com/urfave/cli/v2)) bundled(golang(github.com/valyala/fastjson)) bundled(golang(github.com/x448/float16)) bundled(golang(github.com/xanzy/ssh-agent)) bundled(golang(github.com/xi2/xz)) bundled(golang(github.com/xrash/smetrics)) bundled(golang(github.com/yohcop/openid-go)) bundled(golang(github.com/yuin/goldmark)) bundled(golang(github.com/yuin/goldmark-highlighting/v2)) bundled(golang(github.com/zeebo/assert)) bundled(golang(github.com/zeebo/blake3)) bundled(golang(gitlab.com/gitlab-org/api/client-go)) bundled(golang(go.etcd.io/bbolt)) bundled(golang(go.uber.org/atomic)) bundled(golang(go.uber.org/mock)) bundled(golang(go.uber.org/multierr)) bundled(golang(go.uber.org/zap)) bundled(golang(go.uber.org/zap/exp)) bundled(golang(golang.org/x/crypto)) bundled(golang(golang.org/x/image)) bundled(golang(golang.org/x/mod)) bundled(golang(golang.org/x/net)) bundled(golang(golang.org/x/oauth2)) bundled(golang(golang.org/x/sync)) bundled(golang(golang.org/x/sys)) bundled(golang(golang.org/x/text)) bundled(golang(golang.org/x/time)) bundled(golang(golang.org/x/tools)) bundled(golang(google.golang.org/protobuf)) bundled(golang(gopkg.in/alexcesaro/quotedprintable.v3)) bundled(golang(gopkg.in/gomail.v2)) bundled(golang(gopkg.in/ini.v1)) bundled(golang(gopkg.in/warnings.v0)) bundled(golang(gopkg.in/yaml.v3)) bundled(golang(mvdan.cc/xurls/v2)) bundled(golang(xorm.io/builder)) bundled(golang(xorm.io/xorm)) config(forgejo) forgejo forgejo(x86-64) group(forgejo) user(forgejo) Diff spec file in url and in SRPM --------------------------------- --- /home/humaton/2354888-forgejo/srpm/forgejo.spec 2025-06-25 13:47:30.364456613 +0200 +++ /home/humaton/2354888-forgejo/srpm-unpacked/forgejo.spec 2025-06-25 02:00:00.000000000 +0200 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %bcond check 1 @@ -214,3 +224,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Jun 25 2025 Nils Philippsen <nils@xxxxxxxxx> - 11.0.2-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2354888 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Java, Ruby, Ocaml, Python, Haskell, SugarActivity, fonts, Perl, R, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH With some warnings and fixes the package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354888%23c80 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
