https://bugzilla.redhat.com/show_bug.cgi?id=2373806 --- Comment #15 from Gerald Cox <gbcox@xxxxxx> --- Jerry, thanks very much for the quick turnaround. Here are the issues you pointed out, and the steps I took to address: 1. The Summary line in the binary RPM is, literally, "$(summary)". You want %{summary} instead of $(summary). Fixed. Thanks! 2. When the tests run, I see lots of these warnings: Thanks for the recommendation. I adopted it. 3. You don't actually need the "%global commit" line... Thanks. I switched to pypi per your advice. 4. I want to make sure you are aware that a declarative buildsystem is now available, and can make your spec file even more succinct. Again, thank you for the suggestion. I was not aware, and I have implemented it. spec: https://download.copr.fedorainfracloud.org/results/gbcox/dogfood/fedora-rawhide-x86_64/09205356-python-lap/python-lap.spec srpm: https://download.copr.fedorainfracloud.org/results/gbcox/dogfood/fedora-rawhide-x86_64/09205356-python-lap/python-lap-0.5.12-1.fc43.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2373806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373806%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
