[Bug 2373805] Review Request: golang-codeberg-gbcox-beetbrainz - Go-based webhook listener

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2373805



--- Comment #10 from Gerald Cox <gbcox@xxxxxx> ---
Hello Jerry,

Thank you for the review and the excellent feedback. 
Much appreciated!

Here's the current status on each of your points:

1. No debuginfo or debugsource packages and hardcoded LDFLAGS:

I've adopted your suggestions, thanks!

2. unused-direct-shlib-dependency /usr/bin/beetbrainz /lib64/libresolv.so.2 and
missing -Wl,--as-needed:

I believe that is a false flag from rpmlint. beetbrainz is a webhook listener
and network application, meaning libresolv.so.2 (which handles DNS lookups) is
needed for its core functionality. Even though --as-needed is correctly
specified via %{build_ldflags}, Go's external linking process often includes
libresolv because its network routines or CGo interactions genuinely depend on
it, making the dependency used rather than unused.

3. Possibility of creating a man page:

Good idea, I created one and it is in the tarball as beetbrainz.8.

However, despite the file being physically present in the buildroot immediately
after installation (confirmed by ls -l in %install), every attempt to package
beetbrainz.8 as a manual page has consistently resulted in an "error: File not
found" during the RPM packaging's %files section processing.
For diagnostic purposes, when the same file was renamed to beetbrainz.txt and
packaged as a generic documentation file (%doc in %{_docdir}), the build
completed successfully without error. This strongly indicates that the problem
is not with the file's presence or basic installability, but specifically with
RPM's internal processing or validation routines for files identified as system
manual pages within this particular build environment.
While the man page is intended to be included, and I've tried various standard
methods, I've had to temporarily omit its packaging to allow the package to
build (hence the W: no-manual-page-for-binary beetbrainz warning ). If you have
an idea of something to try, I'd appreciate hearing it.  Otherwise, I'll follow
up with the GOLANG sig and see if they might have a clue as to what is going
on. 

spec:
https://download.copr.fedorainfracloud.org/results/gbcox/dogfood/fedora-rawhide-x86_64/09205041-golang-codeberg-gbcox-beetbrainz/golang-codeberg-gbcox-beetbrainz.spec
srpm:
https://download.copr.fedorainfracloud.org/results/gbcox/dogfood/fedora-rawhide-x86_64/09205041-golang-codeberg-gbcox-beetbrainz/golang-codeberg-gbcox-beetbrainz-1.0.12-1.20250624gitef649cd.fc43.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2373805

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373805%23c10

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux