https://bugzilla.redhat.com/show_bug.cgi?id=2055602 andreyesquivel.dev@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreyesquivel.dev@proton.m | |e --- Comment #8 from andreyesquivel.dev@xxxxxxxxx --- Hello team, This is my mock review for Fedora sponsorship process. Spec file observations: Version: 3.0.4 (note that 3.0.5 is available, you should consider updating to the latest version) Summary: Quickly show all your terminal colours Currently, uses "colours". You must change to "colors." (see https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/) Source0: Currently, points to the master branch ZIP: https://github.com/pablopunk/%{name}/archive/refs/heads/master.zip Consider replacing it with the tarball URL format: %{url}/archive/%{version}/%{name}-%{version}.tar.gz (see https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags) %prep section: Consider using: %autosetup -n -p0 (see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_autosetup) %install section: Consider specifying the exact filename: install -m 0755 %{name} %{buildroot}/%{_bindir}/%{name} (see https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/) Consider creating a manpage using the tool help2man to avoid "W: no-manual-page-for-binary colortest" during rpmlint test (see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages). This will also improve package quality. I hope this review is helpful for other reviewers. I am available to assist with any further questions or clarifications. Feedback is always welcome. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2055602 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202055602%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
