[Bug 2373806] Review Request: python3-lap - This package provides the 'lap' Python library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2373806



--- Comment #8 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
(In reply to Gerald Cox from comment #7)
> %check
> # Minimal smoke test that verifies installation without importing C
> extensions
> %{python3} -c "
> import sys
> sys.path.insert(0, '%{buildroot}%{python3_sitearch}')
> try:
>     import lap
>     print(f'Package installed at: {lap.__file__}')
>     # Skip actual tests that require C extensions
>     print('Skipping C extension tests in mock environment')
>     sys.exit(0)
> except ImportError as e:
>     print(f'Critical installation error: {e}')
>     sys.exit(1)
> "

There is nothing reasonable about this. It is overcomplicated, confusing,
misleading and wrong. It tries to avoid testing the compiled extensions (which,
by the way, are not written in C), when that is exactly the one thing that you
want to do. Listening to AI is not a good idea here. You need to use your own
brain, ask questions, and read documentation to get a good result.

I’m going to attach a basic, clean spec file to demonstrate how this could be
packaged. Feel free to use it, either verbatim or with modifications, as long
as you get to the point where you understand what is happening and why.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2373806

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373806%23c8

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux