[Bug 2369466] Review Request: nodejs24 - JavaScript runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2369466



--- Comment #9 from Jan Staněk <jstanek@xxxxxxxxxx> ---
Working on the issues. Progress so far:

> nodejs24-npm.x86_64: E: invalid-locale-man-dir /usr/share/man/nodejs-24/man1/npm-undeprecate.1.gz
Moved the versioned man dir into /usr/share/node-24/man
(%{nodejs_datadir}/man). This has the unfortunate side effect of not
compressing the man pages automatically, but changing the symlinks to point to
compressed names (ending in .gz), thus making them dangling. Solved for now by
compressing the man pages manually; this is possibly something up for further
discussion, but I feel not worth blocking on right now.

> nodejs24-npm.x86_64: E: zero-length /usr/lib/node_modules_24/npm/.npmrc
This seems to be an upstream configuration for maintaining npm using npm, and
should not be needed for installations at all. I have remove this one to avoid
confusion with the distro-wide npmrc that we create.

There are some other files in npm deps that are empty, but as we generally do
not touch these dependencies, they should be safe to ignore.

> nodejs24-full-i18n.x86_64: E: no-binary
Well, there is no executable binary, but there is a architecture-dependent data
file – the Unicode database. Either little- or big-endian version is installed,
depending on the architecture, and we do not want to mix those. Hence, this
cannot be noarch.

> nodejs24-npm.x86_64: E: no-binary
This is more up to debate, the npm is currently not containing any
architecture-specific binary files (just javascript), but it can grow one in
deps at any time, if a native extension anywhere is introduced. OTOH, that
introduction should fail the build, so I'll probably be adding the `BuildArch:
noarch` here. WDYT?

New spec and SRPM incoming once the current COPR run finishes.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2369466

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202369466%23c9

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux