https://bugzilla.redhat.com/show_bug.cgi?id=2373034 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |benson_muite@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |benson_muite@xxxxxxxxxxxxx --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-capnet-assist See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v2.0 or later". 439 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/elementary-capnet- assist/2373034-elementary-capnet-assist/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/mo [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/mo, /usr/share/locale/mo/LC_MESSAGES [ ]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1487 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1064960 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: elementary-capnet-assist-8.0.1-1.fc43.x86_64.rpm elementary-capnet-assist-8.0.1-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpecv9gawz')] checks: 32, packages: 2 elementary-capnet-assist.x86_64: W: no-manual-page-for-binary io.elementary.capnet-assist elementary-capnet-assist.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/io.elementary.capnet-assist.mo elementary-capnet-assist.x86_64: E: files-duplicated-waste 129513 elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/128x128@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/128x128/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/16x16@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/16x16/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/24x24@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/24x24/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/32x32@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/32x32/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/48x48@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/48x48/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/64x64@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/64x64/apps/io.elementary.capnet-assist.svg 2 packages and 0 specfiles checked; 2 errors, 7 warnings, 7 filtered, 2 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: elementary-capnet-assist-debuginfo-8.0.1-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp68tjghns')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 elementary-capnet-assist.x86_64: W: no-manual-page-for-binary io.elementary.capnet-assist elementary-capnet-assist.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/io.elementary.capnet-assist.mo elementary-capnet-assist.x86_64: E: files-duplicated-waste 129513 elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/128x128@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/128x128/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/16x16@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/16x16/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/24x24@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/24x24/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/32x32@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/32x32/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/48x48@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/48x48/apps/io.elementary.capnet-assist.svg elementary-capnet-assist.x86_64: W: files-duplicate /usr/share/icons/hicolor/64x64@2/apps/io.elementary.capnet-assist.svg /usr/share/icons/hicolor/64x64/apps/io.elementary.capnet-assist.svg 2 packages and 0 specfiles checked; 2 errors, 7 warnings, 9 filtered, 2 badness; has taken 0.6 s Source checksums ---------------- https://github.com/elementary/capnet-assist/archive/8.0.1/capnet-assist-8.0.1.tar.gz : CHECKSUM(SHA256) this package : 8219a21d8e156ab4f885588d9d4edcf12fe60e43581ca63cc131badfd0a074a6 CHECKSUM(SHA256) upstream package : 8219a21d8e156ab4f885588d9d4edcf12fe60e43581ca63cc131badfd0a074a6 Requires -------- elementary-capnet-assist (rpmlib, GLIBC filtered): NetworkManager hicolor-icon-theme libadwaita-1.so.0()(64bit) libadwaita-1.so.0(LIBADWAITA_1_0)(64bit) libc.so.6()(64bit) libgcr-4.so.4()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgranite-7.so.7()(64bit) libgtk-4.so.1()(64bit) libwebkitgtk-6.0.so.4()(64bit) rtld(GNU_HASH) Provides -------- elementary-capnet-assist: application() application(io.elementary.capnet-assist.desktop) elementary-capnet-assist elementary-capnet-assist(x86-64) metainfo() metainfo(io.elementary.capnet-assist.metainfo.xml) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2373034 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Python, Ocaml, C/C++, R, Java, PHP, Perl, Haskell, SugarActivity, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Raised issue about licensing upstream: https://github.com/elementary/capnet-assist/issues/132 b) svg icon should just go into %{_datadir}/icons/hicolor/scalable/apps/%{appname}.svg Can the other copies be removed? c) To get moldovian directory ownership fixed, https://src.fedoraproject.org/rpms/filesystem/pull-request/28 needs to be merged d) May want to put the language translation files in a noarch subpackage. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2373034 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373034%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
