https://bugzilla.redhat.com/show_bug.cgi?id=2370890 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Just a few comments: ``` %post %systemd_post acmesh-renew.timer # Remind users to start acmesh-renew.timer if they need acme.sh to automatically renew certs if [ "$1" -eq 1 ] ; then echo "" echo "acme.sh auto renewal timer is not started by default." echo "Run 'systemctl start acmesh-renew.timer' to enable automatic renewals." fi %preun %systemd_preun acmesh-renew.timer %postun %systemd_postun_with_restart acmesh-renew.timer ``` I'm pretty sure this not what you want here. I don't think restarting a timer doesn't do anything ... and printing output in RPM scriptlets is very frowned upon. I would just do what's documented in the Packaging Guidelines for systemd services: ``` %post %systemd_post acmesh-renew.service %preun %systemd_preun acmesh-renew.service %postun %systemd_postun_with_restart acmesh-renew.service ``` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2370890 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202370890%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
