https://bugzilla.redhat.com/show_bug.cgi?id=2373806 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx --- Comment #3 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- spec: https://download.copr.fedorainfracloud.org/results/gbcox/dogfood/fedora-rawhide-x86_64/09181215-python3-lap/python3-lap.spec srpm: https://download.copr.fedorainfracloud.org/results/gbcox/dogfood/fedora-rawhide-x86_64/09181215-python3-lap/python3-lap-0.5.12-1.fc43.src.rpm Initial comments: a) Consider fully using the new build macros, in particular change: %prep %autosetup -p1 -n lap-%{version} %build %pyproject_wheel %install %pyproject_install %files %license LICENSE %{python3_sitearch}/lap/ %{python3_sitearch}/lap-%{version}.dist-info/ to %autosetup -p1 -n lap-%{version} %generate_buildrequires %pyproject_buildrequires %build %pyproject_wheel %install %pyproject_install %pyproject_save_files -l lap %check %pyproject_check_import %pytest %files -n python3-lap -f %{pyproject_files} %changelog %autochangelog b) With buildrequires automatically generated, you only need BuildRequires: python3-devel BuildRequires: gcc-c++ c) Please also remove Provides: python3.13dist(lap) = %{version} Requires: python3.13dist(numpy) >= 1.20 these should be automatically generated. d) Consuder using pyp2spec to generate python package spec files. e) Consider getting sources from GitHub if pypi sources do not have tests f) License seems to be BSD-3-Clause -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2373806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373806%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
