https://bugzilla.redhat.com/show_bug.cgi?id=2358954 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #21 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thank you for your work, this looks good now! Some last comments and one non-blocking suggestion included below, but the package is APPROVED. --- > Update to 0.10.3 which fixed the license and bundling. I can actually make the yaml-test-suite work, but I will tackle that later after conference season is over. Any objections for adding a Source2 with the git archive of yaml-test-suite later on? No, I have no objections to that, it sounds like a good solution all around. You'll even only need to unpack those sources in %check so there's no way they could even get installed as part of the built packages. --- Note that the statement in the LICENSE file is now inaccurate (it's only "MIT OR Apache-2.0" now, not "either only MIT or MIT AND Apache-2.0"), but at least the package is correct now and we will ignore that statement in the LICENSE file because we know it's wrong ;) --- Last suggestion (but this is not blocking the review): Shipping "hidden" files / folders is usually frowned upon in packaging. I would recommend that you replace > install -Dp .licenses/* -t %{buildroot}%{crate_instdir}/.licenses after %cargo_install with something like > mv .licenses/* ./ && rmdir .licenses *before* %cargo_install, and list the files as just %license "%{crate_instdir}/LICENSE-Apache" and "%{crate_instdir}/LICENSE-MIT". You can even do both in rust2rpm.toml by setting `package.license-files = ["LICENSE-Apache", "LICENSE-MIT"]` and putting the pre-%cargo_install steps into the `scripts.install.pre` setting. --- Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2358954 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358954%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
