https://bugzilla.redhat.com/show_bug.cgi?id=2369997 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review. (In reply to Benson Muite from comment #2) > Comments: > a) Makefiles have acceptance tests, though they do not seem to be used in > the current > CI setup upstream > https://github.com/cucumber/gherkin/blob/main/cpp/Makefile > https://github.com/cucumber/gherkin/blob/main/c/Makefile > can these be used? The acceptance tests compare outputs using a diff, > so they seem to fail when there are small changes: > https://koji.fedoraproject.org/koji/taskinfo?taskID=134073780 I reported the failures upstream in https://github.com/cucumber/gherkin/issues/412. This has resulted in some fixes for C++: https://github.com/cucumber/gherkin/pull/414, https://github.com/cucumber/gherkin/pull/415, and https://github.com/cucumber/gherkin/pull/416. After those get reviewed and merged, and hopefully we can fix C as well, I’ll see if I can get the acceptance tests running in the RPM build and offer an updated submission. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2369997 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202369997%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
