https://bugzilla.redhat.com/show_bug.cgi?id=2371328 --- Comment #12 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- > # Icon png taken from MyGUI's website for Tools desktop files > Source4: mygui.png This seems unnecessary, there are icons included in the source tarball at Media/Common/Sources/Icons, e.g. MyGUI_Icon_LE_256x256.png. > # Put the mygui.png icon in MyGUI's datadir. > install %{SOURCE4} %{buildroot}%{_datadir}/MYGUI/mygui.png Icons usually go into %{_datadir}/pixmaps (or under %{_iconsdir}/hicolor/). Or is this path hard-coded somewhere? > Icon=/usr/share/MYGUI/mygui.png The preferred way is to have no path, just the file name without the extension. If you use Icon=mygui_fe and put the icons in subdirectories like this: for size in 16 24 32 48 96 256 ; do install -Dpm644 Media/Common/Sources/Icons/MyGUI_Icon_FE_${size}x${size}.png %{buildroot}%{_iconsdir}/hicolor/${size}x${size}/apps/mygui_fe.png done then the desktop environment will pick the closest icon size automatically when displaying it. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2371328 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202371328%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
