https://bugzilla.redhat.com/show_bug.cgi?id=2317888 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Link ID| |Github | |ngtcp2/ngtcp2/issues/1673 --- Comment #25 from Petr Menšík <pemensik@xxxxxxxxxx> --- Created upstream issue https://github.com/ngtcp2/ngtcp2/issues/1673 Tried enabling tests building, but they fail to compile with default package flags. Both on my f41 and rawhide. I lack time to create PR fixing these, but it should not be hard to fix properly. make[2]: Leaving directory '/builddir/build/BUILD/ngtcp2-1.13.0-build/ngtcp2-1.13.0/tests' make[2]: Entering directory '/builddir/build/BUILD/ngtcp2-1.13.0-build/ngtcp2-1.13.0/tests' gcc -DHAVE_CONFIG_H -I. -I.. -Wall -Wextra -Werror -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wdeclaration-after-statement -Wformat-security -Wwrite-strings -Wshadow -Winline -Wnested-externs -Wfloat-equal -Wundef -Wendif-labels -Wempty-body -Wcast-align -Wclobbered -Wvla -Wpragmas -Wunreachable-code -Waddress -Wattributes -Wdiv-by-zero -Wconversion -Wformat-nonliteral -Wmissing-field-initializers -Wmissing-noreturn -Wmissing-variable-declarations -Wsign-conversion -Wunused-parameter -Wredundant-decls -Wheader-guard -Wduplicated-branches -Wno-format-nonliteral -I../lib -I../lib/includes -I../tests/munit -I../lib/includes -DBUILDING_NGTCP2 -DHAVE_CONFIG_H -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -c -o ngtcp2_conn_test.o ngtcp2_conn_test.c make[2]: Leaving directory '/builddir/build/BUILD/ngtcp2-1.13.0-build/ngtcp2-1.13.0/tests' make[2]: Entering directory '/builddir/build/BUILD/ngtcp2-1.13.0-build/ngtcp2-1.13.0/tests' /bin/sh ../libtool --tag=CC --mode=link gcc -Wall -Wextra -Werror -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wdeclaration-after-statement -Wformat-security -Wwrite-strings -Wshadow -Winline -Wnested-externs -Wfloat-equal -Wundef -Wendif-labels -Wempty-body -Wcast-align -Wclobbered -Wvla -Wpragmas -Wunreachable-code -Waddress -Wattributes -Wdiv-by-zero -Wconversion -Wformat-nonliteral -Wmissing-field-initializers -Wmissing-noreturn -Wmissing-variable-declarations -Wsign-conversion -Wunused-parameter -Wredundant-decls -Wheader-guard -Wduplicated-branches -Wno-format-nonliteral -I../lib -I../lib/includes -I../tests/munit -I../lib/includes -DBUILDING_NGTCP2 -DHAVE_CONFIG_H -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -static -Wl,-z,relro -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-hardened-ld-errors -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes -o main main.o ngtcp2_pkt_test.o ngtcp2_range_test.o ngtcp2_rob_test.o ngtcp2_acktr_test.o ngtcp2_map_test.o ngtcp2_transport_params_test.o ngtcp2_rtb_test.o ngtcp2_idtr_test.o ngtcp2_conn_test.o ngtcp2_ringbuf_test.o ngtcp2_conv_test.o ngtcp2_ksl_test.o ngtcp2_gaptr_test.o ngtcp2_vec_test.o ngtcp2_strm_test.o ngtcp2_pv_test.o ngtcp2_pmtud_test.o ngtcp2_str_test.o ngtcp2_tstamp_test.o ngtcp2_cc_test.o ngtcp2_qlog_test.o ngtcp2_window_filter_test.o ngtcp2_settings_test.o ngtcp2_ppe_test.o ngtcp2_dcidtr_test.o ngtcp2_addr_test.o ngtcp2_test_helper.o munit/munit.o ../lib/.libs/*.o libtool: link: gcc -Wall -Wextra -Werror -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wdeclaration-after-statement -Wformat-security -Wwrite-strings -Wshadow -Winline -Wnested-externs -Wfloat-equal -Wundef -Wendif-labels -Wempty-body -Wcast-align -Wclobbered -Wvla -Wpragmas -Wunreachable-code -Waddress -Wattributes -Wdiv-by-zero -Wconversion -Wformat-nonliteral -Wmissing-field-initializers -Wmissing-noreturn -Wmissing-variable-declarations -Wsign-conversion -Wunused-parameter -Wredundant-decls -Wheader-guard -Wduplicated-branches -Wno-format-nonliteral -I../lib -I../lib/includes -I../tests/munit -I../lib/includes -DBUILDING_NGTCP2 -DHAVE_CONFIG_H -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,pack-relative-relocs -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-hardened-ld-errors -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes -o main main.o ngtcp2_pkt_test.o ngtcp2_range_test.o ngtcp2_rob_test.o ngtcp2_acktr_test.o ngtcp2_map_test.o ngtcp2_transport_params_test.o ngtcp2_rtb_test.o ngtcp2_idtr_test.o ngtcp2_conn_test.o ngtcp2_ringbuf_test.o ngtcp2_conv_test.o ngtcp2_ksl_test.o ngtcp2_gaptr_test.o ngtcp2_vec_test.o ngtcp2_strm_test.o ngtcp2_pv_test.o ngtcp2_pmtud_test.o ngtcp2_str_test.o ngtcp2_tstamp_test.o ngtcp2_cc_test.o ngtcp2_qlog_test.o ngtcp2_window_filter_test.o ngtcp2_settings_test.o ngtcp2_ppe_test.o ngtcp2_dcidtr_test.o ngtcp2_addr_test.o ngtcp2_test_helper.o munit/munit.o ../lib/.libs/ngtcp2_acktr.o ../lib/.libs/ngtcp2_addr.o ../lib/.libs/ngtcp2_balloc.o ../lib/.libs/ngtcp2_bbr.o ../lib/.libs/ngtcp2_buf.o ../lib/.libs/ngtcp2_cc.o ../lib/.libs/ngtcp2_cid.o ../lib/.libs/ngtcp2_conn.o ../lib/.libs/ngtcp2_conv.o ../lib/.libs/ngtcp2_crypto.o ../lib/.libs/ngtcp2_dcidtr.o ../lib/.libs/ngtcp2_err.o ../lib/.libs/ngtcp2_frame_chain.o ../lib/.libs/ngtcp2_gaptr.o ../lib/.libs/ngtcp2_idtr.o ../lib/.libs/ngtcp2_ksl.o ../lib/.libs/ngtcp2_log.o ../lib/.libs/ngtcp2_map.o ../lib/.libs/ngtcp2_mem.o ../lib/.libs/ngtcp2_objalloc.o ../lib/.libs/ngtcp2_opl.o ../lib/.libs/ngtcp2_path.o ../lib/.libs/ngtcp2_pkt.o ../lib/.libs/ngtcp2_pmtud.o ../lib/.libs/ngtcp2_ppe.o ../lib/.libs/ngtcp2_pq.o ../lib/.libs/ngtcp2_pv.o ../lib/.libs/ngtcp2_qlog.o ../lib/.libs/ngtcp2_range.o ../lib/.libs/ngtcp2_ringbuf.o ../lib/.libs/ngtcp2_rob.o ../lib/.libs/ngtcp2_rst.o ../lib/.libs/ngtcp2_rtb.o ../lib/.libs/ngtcp2_settings.o ../lib/.libs/ngtcp2_str.o ../lib/.libs/ngtcp2_strm.o ../lib/.libs/ngtcp2_transport_params.o ../lib/.libs/ngtcp2_unreachable.o ../lib/.libs/ngtcp2_vec.o ../lib/.libs/ngtcp2_version.o ../lib/.libs/ngtcp2_window_filter.o make[2]: Leaving directory '/builddir/build/BUILD/ngtcp2-1.13.0-build/ngtcp2-1.13.0/tests' In function 'ngtcp2_ringbuf_push_front', inlined from 'test_ngtcp2_ringbuf_push_front' at ngtcp2_ringbuf_test.c:56:15, inlined from 'wrap_test_ngtcp2_ringbuf_push_front' at ngtcp2_ringbuf_test.h:38:1: ../lib/ngtcp2_ringbuf.c:88:10: error: 'rb.buf' may be used uninitialized [-Werror=maybe-uninitialized] 88 | return (void *)&rb->buf[rb->first * rb->size]; | ^ ngtcp2_ringbuf_test.c: In function 'wrap_test_ngtcp2_ringbuf_push_front': ngtcp2_ringbuf_test.c:49:18: note: 'rb.buf' was declared here 49 | ngtcp2_ringbuf rb; | ^ In function 'ngtcp2_ringbuf_push_front', inlined from 'test_ngtcp2_ringbuf_pop_front' at ngtcp2_ringbuf_test.c:85:15, inlined from 'wrap_test_ngtcp2_ringbuf_pop_front' at ngtcp2_ringbuf_test.h:39:1: ../lib/ngtcp2_ringbuf.c:88:10: error: 'rb.buf' may be used uninitialized [-Werror=maybe-uninitialized] 88 | return (void *)&rb->buf[rb->first * rb->size]; | ^ ngtcp2_ringbuf_test.c: In function 'wrap_test_ngtcp2_ringbuf_pop_front': ngtcp2_ringbuf_test.c:78:18: note: 'rb.buf' was declared here 78 | ngtcp2_ringbuf rb; | ^ lto1: all warnings being treated as errors make[3]: *** [/tmp/ccm8nudj.mk:20: /tmp/ccyJPBCV.ltrans9.ltrans.o] Error 1 make[3]: *** Waiting for unfinished jobs.... ngtcp2_vec_test.c: In function 'test_ngtcp2_vec_copy_at_most': ngtcp2_vec_test.c:605:9: error: 'src' may be used uninitialized [-Werror=maybe-uninitialized] 605 | n = ngtcp2_vec_copy_at_most(dst, 0, src, 0, 100); | ^ ../lib/ngtcp2_vec.c:190:8: note: by argument 3 of type 'const struct ngtcp2_vec *' to 'ngtcp2_vec_copy_at_most' declared here 190 | size_t ngtcp2_vec_copy_at_most(ngtcp2_vec *dst, size_t dstcnt, | ^ ngtcp2_vec_test.c:603:22: note: 'src' declared here 603 | const ngtcp2_vec src[1]; | ^ lto1: all warnings being treated as errors make[3]: *** [/tmp/ccm8nudj.mk:22: /tmp/ccyJPBCV.ltrans10.ltrans.o] Error 1 lto-wrapper: fatal error: make returned 2 exit status compilation terminated. /usr/bin/ld: error: lto-wrapper failed collect2: error: ld returned 1 exit status -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2317888 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317888%23c25 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue