[Bug 2368737] Review Request: cef - Chromium Embedded Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2368737



--- Comment #12 from Asahi Lina <lina@xxxxxxxxxxxxx> ---
After speaking to the CEF folks and thinking about this some more, we decided
to drop the idea of packaging a prebuilt libcef_wrapper and instead ship the
source code plus a FindCEF.cmake module that sets up the library target to
build as part of the consumer. This more closely follows how CEF is intended to
be used, and means consumers can configure their own build flags for the CEF
wrapper lib. It also simplifies the spec file and removes some footguns. So now
there is a single `cef-devel` package that ships the wrapper source, which may
be built for any given library API version.

This also simplifies the OBS package changes. Now the only change needed is to
just remove the FindCEF.cmake that OBS ships, and then it will use the system
one and everything works. The CEF API version can be specified via CMake
define.

For reference, these are the WIP changes to the spec file:
https://gist.github.com/asahilina/a64976b6bad98e7df9d42900f963cf6f
And this is FindCEF.cmake:
https://gist.github.com/asahilina/bc3537becfb397b9303278fc09dc06ef


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2368737

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368737%23c12

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux