https://bugzilla.redhat.com/show_bug.cgi?id=2353410 --- Comment #7 from Steve <skrochen@xxxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/s-kro/libfungw/fedora-rawhide-x86_64/09150605-libfungw/libfungw.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/s-kro/libfungw/fedora-rawhide-x86_64/09150605-libfungw/libfungw-1.2.1-3.fc43.src.rpm Thanks for the feedback > a) Koji build > BuildError: The following noarch package built differently on different architectures: libfungw-doc-1.2.1-2.fc43.noarch.rpm > rpmdiff output was: > removed REQUIRES libfungw(x86-32) = 1.2.1-2.fc43 > added REQUIRES libfungw(x86-64) = 1.2.1-2.fc43 > It maybe easier to add the license file to the doc subpackage and not have it require any other package, but be recommended. Done. I *think* I did this properly :/ > b) Consider using %autorelease and %autochangelog macros Started. Will try to further incorporate these in the next upstream bump > c) License seems like it should be > LGPL-2.0-or-later AND LGPL-2.1-or-later AND BSD-3-Clause Done > d) There are many plugins under > /usr/lib/puplug > They should be in > %{_libdir}/puplug > on i686 this will be > /usr/lib/puplug > but on 64 bit architectures this will be > /usr/lib64/puplug Understood. But this is the way upstream wants it because of how he calls them in the dependent packages (If you need a more articulate explanation I can get him to re-explain it to me) > e) genht sems to be bundled, see src_3rd/genht/ can it be packaged separately? It is. I didn't see any if these in the packaged files and there is already a bug report related requesting a sponsor for that package. > http://repo.hu/projects/genht > f) Can perl bindings be built? Done! Tried to incorporated gpgverify, but it didn't like the upstream keyring. I may need guidance on this Steve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2353410 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353410%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
