https://bugzilla.redhat.com/show_bug.cgi?id=2371328 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- Just a few quick nitpicks before doing a proper review: > Source0: https://github.com/MyGUI/mygui/archive/MyGUI3.4.3/mygui-MyGUI%{version}.tar.gz This uses the %{version} macro in one place, but not in the other. Could probably be replaced with: https://github.com/MyGUI/mygui/archive/MyGUI%{version}/mygui-MyGUI%{version}.tar.gz > %if 0%{?fedora} > 41 > Requires: sdl2-compat > %else > Requires: SDL2 > %endif This is unnecessary; sdl2-compat has "Provides: SDL2". > %package tools > Summary: MyGUI tools > Requires: %{name} = %{version}-%{release} This should probably be an archful dependency: "%{name}%{?_isa} = %{version}-%{release}". https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package (Same deal for the devel package.) > %build > [...] > cd redhat-linux-build It might be safer to use %{_vpath_builddir} here. > %install > rm -rf %{buildroot} "The contents of the buildroot SHOULD NOT be removed in the first line of %install." https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > install -D %{_buildrootdir}/mygui-MyGUI%{version}/redhat-linux-build/Docs/html/* %{buildroot}%{_datadir}/doc/mygui-devel-doc/html You don't need to specify the full path to the source file, using "redhat-linux-build/Docs/html*" should work fine. (Or, as noted above, "%{_vpath_builddir}/Docs/html/*". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2371328 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202371328%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
