https://bugzilla.redhat.com/show_bug.cgi?id=2361600 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(leonardi@redhat.c | |om) --- Comment #14 from Cole Robinson <crobinso@xxxxxxxxxx> --- > I don't think we need `Requires: %{name} = %{version}-%{release}` for > `devel` and `tools` since the `igvm` package is not created. WDYT? Yeah that's fine. I tried a scratch build, and i686 failed, the .a file wasn't generated. Not worth figuring out, just add `ExcludeArch: %{ix86}" rpmlint points out some issues with dump_igvm: igvm-tools.x86_64: W: unused-direct-shlib-dependency /usr/bin/dump_igvm /lib64/libm.so.6 igvm-tools.x86_64: W: unstripped-binary-or-object /usr/bin/dump_igvm igvm-tools.x86_64: W: position-independent-executable-suggested /usr/bin/dump_igvm I _think_ these are all due to igvm_c/Makefile ignoring CFLAGS and friends when building dump_igvm. rpm exports CFLAGS at beginning of %build/%install/%check phases but the Makefile isn't adhering to them. Is dump_igvm useful? The code is in a `sample/` directory upstream so not sure if it's just a demo app or not. Maybe it's simpler to delete it from packaging. After those bits I think everything is good to go -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2361600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202361600%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
