[Bug 2360119] Review Request: virt-firmware-rs - virt firmware rust tools and efi apps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2360119



--- Comment #20 from Gerd Hoffmann <kraxel@xxxxxxxxxx> ---
> d) W: unused-direct-shlib-dependency
> {/usr/bin/generate-boot-csv,/usr/bin/uefi-boot-menu) /lib64/libudev.so.1
> 
> Not sure why this is happening - do those subprojects have a dependency on
> the udev bindings but don't actually use them?
> But this might be a harmless warning in either case.

libefi has a module which uses udev.  Both binaries use the library
but not the module.  Apparently rust links in libudev nevertheless.

> Alternatively, now that all the dependencies needed are present, why not
> drop the conditionals for "do not build_efi_apps" entirely?

It doesn't build on ppc and s390 ...

> 5. It's a bit strange to see architecture-dependent executables getting
> installed under /usr/share ?
> It might be OK to do this for EFI executables since they're not meant to be
> executed on the host OS (I assume), but it's still ... weird. Just making
> sure this is intentional.

It's common practice for firmware.  edk2-ovmf.rpm places firmware images and
efi binaries in /usr/share/edk2/ovmf too.

I've also moved the efi binaries to a noarch sub-rpm, to allow installing it
on non-native archs and run the efi apps in qemu (again following common
packaging practice for firmware).

spec url:
https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/09121431-virt-firmware-rs/virt-firmware-rs.spec
srpm url:
https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/09121431-virt-firmware-rs/virt-firmware-rs-25.5.1-1.fc43.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2360119

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360119%23c20

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux