https://bugzilla.redhat.com/show_bug.cgi?id=2369375 --- Comment #4 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Ben Beasley from comment #2) > I think you need to byte-compile the Python files. Otherwise, this looks > fine. Details below: You're absolutely correct. Thanks for catching that! > Package Review > ============== [...] > The manual dependency on libpeas-loader-python%{_isa} is reasonable since it > apparently cannot be generated; I’m assuming that there is an indirect > dlopen()/ctypes involved at some point in the chain. The comment justifying > it > (“required by yt-dlp enhancer”) could be more detailed, but is adequate. It segfaults (inside libpeas.so) otherwise. Not sure if it's a bug. > Similarly, the manual dependency on python3dist(yt-dlp) is reasonable given > that this is not a Python library package and there is no .dist-info > directory > for the Python code it ships (so there can be no Python dependency metadata). > > ===== Issues ===== > > - Given that the Python sources in the plugins are used by importing them > rather than by executing them as scripts, they must be bytecode-compiled. Will do, thanks for the detailed steps. [...] > I opened https://github.com/Rafostar/clapper-enhancers/pull/15 to fix this > upstream. No change is required in the package submission: I don’t > recommend > patching this downstream, especially before upstream reviews my PR. Thanks! (In reply to Ben Beasley from comment #3) > Oh, one more thing! Please replace > > %global _clapperenhdir /usr/lib64/clapper-0.0/enhancers > > with > > %global _clapperenhdir %{_libdir}/clapper-0.0/enhancers Sure! I can't believe I missed this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2369375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202369375%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
