https://bugzilla.redhat.com/show_bug.cgi?id=2368379 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx Blocks| |182235 (FE-Legal) --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Cristian Le from comment #2) > Just one change, I think it would be better to reverse the dependency and > avoid the `Recommends`. The download link is also weird and unversioned, but > unless you can contact upstream about it, I guess it's good as-is. > > There is the license of this, which I am uncertain about, maybe you can have > the license team review this? Are you just speaking of CC-BY-4.0 AND CC-BY-2.0? Both are allowed for content in Fedora, https://docs.fedoraproject.org/en-US/legal/allowed-licenses/#_allowed_content_licenses, and this package would appear to comprise only content, so I think that part should be OK. It would make sense to add a spec-file comment above License pointing out that CAreadme.txt contains a detailed explanation of which files are covered under which license(s). While the stated licenses for the models themselves are clearly allowed, I do think it would be worth checking whether or not Fedora Legal is concerned about this package being encumbered by any IP rights Lego may have in the designs that the models describe. One other point: The registered trademark symbol ® MUST NOT appear in the package summary or description: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in_summary_or_description Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2368379 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368379%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
