[Bug 2351032] Review Request: python-tatsu - Python parser generator from grammars in a variation of EBNF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2351032

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Looking at the spec-file diff, all requested changes that were required for
approval have been correctly implemented, and there is no reason to believe any
new problems might have been introduced. The package is therefore APPROVED.

--- ../../srpm-unpacked/python-tatsu.spec       2025-05-29 20:00:00.000000000
-0400
+++ srpm-unpacked/python-tatsu.spec     2025-05-30 20:00:00.000000000 -0400
@@ -6,14 +6,17 @@
 Release:        %autorelease
 Summary:        Python parser generator from grammars in a variation of EBNF

-License:        BSD-4-Clause
+License:        BSD-3-Clause-Attribution
 URL:            https://tatsu.readthedocs.io
 # PyPI tarball doesn't include tests
 Source:         %{forgeurl}/archive/v%{version}/%{srcname}-%{version}.tar.gz
+# Add missing license text for markdown_parser.leg
+Patch:          %{forgeurl}/pull/367.patch

 BuildArch:      noarch
 BuildRequires:  python3-devel
 BuildRequires:  python3-pytest
+BuildRequires:  sed

 %global _description %{expand:
 TatSu is a tool that takes grammars in a variation of EBNF as input, and
@@ -31,6 +34,9 @@
 %prep
 %autosetup -p1 -n %{srcname}-%{version}

+# Drop unneeded shebangs
+sed -r -i '1{/^#!/d}' tatsu/bootstrap.py tatsu/g2e/__init__.py
+
 %generate_buildrequires
 %pyproject_buildrequires -x colorization,parproc

The updated rpmlint output is:

python3-tatsu.noarch: E: spelling-error ('memoizing', '%description -l en_US
memoizing -> memorizing, demonizing, monetizing')
python3-tatsu.noarch: E: spelling-error ('parsers', '%description -l en_US
parsers -> parser, parses, parers')
python3-tatsu.noarch: W: no-manual-page-for-binary g2e
python3-tatsu.noarch: W: no-manual-page-for-binary tatsu
 3 packages and 0 specfiles checked; 2 errors, 2 warnings, 49 filtered, 2
badness; has taken 0.2 s


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2351032

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202351032%23c9

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux