https://bugzilla.redhat.com/show_bug.cgi?id=2367629 --- Comment #21 from Tim Wendt <techtasie@xxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/techtasie/sndio/fedora-rawhide-x86_64/09100658-sndio/sndio.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/techtasie/sndio/fedora-rawhide-x86_64/09100658-sndio/sndio-1.10.0-3.fc43.src.rpm >a) Metapackage does not need a separate license file as it will contain the license file from libs package Thanks for the hint. I removed it. >b) Metapackage should probably not need the devel package. I renamed it to libs-devel because it contains the header for the library. >c) Build warnings that you may want to send upstream: I will do that. >e) Upstream publishes a signature: I added the verification. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2367629 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202367629%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue