https://bugzilla.redhat.com/show_bug.cgi?id=2368535 --- Comment #6 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks for your feedback. (In reply to Akira TAGOH from comment #5) > A few questions/comments after looking roughly: > > * There are no strict rules for font meta packages at the moment though, > what's the reason you didn't simply follow the default naming rule of > %fontmetapkg macro and have an own name of ektype-baloo-2-all? The default > name is obvious from its package name that it is a meta package for font but > ektype-baloo-2-all isn't. Left defaults. The package name also refers to the Devanagari font package, so all is still added to the metapackage. > > * Indic fonts are categorized under "Fonts with less common encodings" in > /usr/share/fontconfig/templates/fontconfig-priorities.txt from > fonts-rpm-templates. Using 60 in config file is too high. that breaks > default font sets. Recommended priority number for optional fonts would be > between 66 and 69. > Done used 67. > * You shouldn't abbrivate a generic family name like sans in your config. it > should be sans-serif. > Done. > * You don't need to test "en" for "lang" in your config. I don't think it > works as expected. > Done. > * For ektype-ballo-2-fonts.conf, multiple test elements means AND operator. > I think what you want to do is to have multiple <match>es per lang. Done. spec: https://fed500.fedorapeople.org/ektype-baloo-2-fonts.spec srpm: https://fed500.fedorapeople.org/ektype-baloo-2-fonts-1.640-1.fc41.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2368535 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368535%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
