https://bugzilla.redhat.com/show_bug.cgi?id=2368933 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- spec sanity: 1. %autorelease is the recommended way now, consider switching to it 2. the description line is too long and rpmlint will complain about it 3. upstream sues pytest to run the tests -- can this be done in %check? and if no, please add a comment that explains why 4. I see no manual %license file in %files, in that case, please add -l to %pyproject_save_files to assert at least one license file is installed Overall, the spec is nice and tidy, no craziness. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2368933 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368933%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
