https://bugzilla.redhat.com/show_bug.cgi?id=2368625 --- Comment #6 from Cristian Le <fedora@xxxxxxxxx> --- (In reply to Benson Muite from comment #3) > (In reply to Cristian Le from comment #2) > > - Do you really need/want to package the documentations. Especially for a > > project like this that would not have a user-facing audience > > Helpful. Sometimes one is offline and wants documentation. Yes, but can it be accessed other than manually navigating to the index.html file? I've heard that KHelpCenter might do some magic, but I think it doesn't read `/usr/share/doc/<pkg>` format. Anyway, at the very least let's avoid the bootstrap. You should be able to export a `PYTHONPATH` if the script requires it to be built first [1] > > - The fact that `test_nb_regression` is failing, is quite telling. I think > > it would be cleaner to just ignore them altogether. > > Helps verify functionality. Up to you on this. Are there PRs that fix this test? > > - I know upstream has quite a lot on his plate, but if you could coordinate > > and merge (as in squash) some of the open PRs, that would make it easier for > > him to catch up with this > > Not a good fit for me. Rarely use Python notebooks. If there are other > things > in HPC/Materials Science that could be useful, happy to help with those. Can > also update pyproject.toml Ok, if I remember, I will give it a shot. [1]: https://sourcegraph.com/search?q=context:global+file:%5C.spec%24+PYTHONPATH&patternType=keyword&sm=0 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2368625 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368625%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
