[Bug 2367133] Review Request: libdfx - A lightweight user-space library that provides APIs to configure the PL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2367133

Benson Muite <benson_muite@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(benson_muite@emai |
                   |lplus.org)                  |



--- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
(In reply to Peter Robinson from comment #2)
> (In reply to Benson Muite from comment #1)
> > If the static library is needed, can it be put in a separate subpackage?
> > https://docs.fedoraproject.org/en-US/packaging-guidelines/
> > #_packaging_static_libraries
> 
> It's needed for some of the FPGA pieces, I put it in the devel package
> because it's used when building those, so basically in conjunction with the
> include files, so I didn't see what value a separate subpackage provided.

Would suggest a static subpackage which can be require the devel package.

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries

Also need to add:
Provides: foo-static = %{version}-%{release}

> 
> > The first part of the soname should not be globbed
> > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries
> 
> Ah, yes, I meant to fix that before I pushed it, I used it in the early
> packaging while I was working out all the bits, will fix.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2367133

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202367133%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux