https://bugzilla.redhat.com/show_bug.cgi?id=2367064 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx --- Comment #1 from Cristian Le <fedora@xxxxxxxxx> --- I don't have qmake experience, so I can't take this one, but it's worth noting that qmake is (un)officially deprecated. Maybe worth following up with [1]. Overall though things look fine, and I could give it a more thorough review if you're fine with it. nitpick: Upstream does not have a clarification section that the license is GPL-2.0-or-later or GPL-2.0-only [1]: https://github.com/leozide/leocad/issues/926 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2367064 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202367064%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
