https://bugzilla.redhat.com/show_bug.cgi?id=2368534 --- Comment #5 from Cristian Le <fedora@xxxxxxxxx> --- Some other things I've found: - The sdist does not have `conftest.py`. That might be needed for running the tests. - `docs/test_tutorials.py` is not actually run by default, so you should be generally safe - All files seems to have `#!/usr/bin/env python3`, you might want to run `%py3_shebang_fix` on all of them, but frankly upstream should not have those shebangs, and instead document using `python3 -m`. The shebang approach does not guarantee that they are running on the same package version - Can/should `pymordemos` be split to a different sub-pkg? We could do it in downstream-only -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2368534 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368534%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
