https://bugzilla.redhat.com/show_bug.cgi?id=2368534 --- Comment #3 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- (In reply to Cristian Le from comment #2) > Some quick preliminary comments: > - the license indicates there are missing licenses from bundled third-party > e.g. `src/pymor/algorithms/genericsolvers.py` (this one is BSD-3-Clause). On > the spec side at least, the `License` field should include all licenses in > the effective wheel (still haven't done the full license review to check the > others) https://github.com/pymor/pymor/pull/2431 > - upstream could use the new PEP639 format to clarify the license bundling > as SPDX. This would also allow to include multiple license files in the > metadata e.g. `LICENSE` and `LICENSE-scipy`. Could you try to convince > upstream to migrate to this (requires bumping minimum hatchling version) https://github.com/pymor/pymor/pull/2429 > - can you document why pytest is not run? Missing pytest-notebook dependency. Other notes ann subpackage requires pytorch which does not install at present: https://bugzilla.redhat.com/show_bug.cgi?id=2368610 An updated build is at: https://koji.fedoraproject.org/koji/taskinfo?taskID=133224743 but waiting for upstream to respond to pull requests and packaging pytest-notebook. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2368534 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368534%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
