https://bugzilla.redhat.com/show_bug.cgi?id=2357921 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #10 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This looks good to me! The new submission addresses everything I found in the original review. The package is APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. The tests are disabled, with adequate justification: -%bcond check 1 +# * tests must be built for *-unknown-uefi target +%bcond check 0 The Summary is appropriately shortened to fit in 80 characters: -Summary: Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality +Summary: Safe, convenient, and performant abstractions for UEFI An extra Source is included for generated code. There is no attempt to actually re-generate the generated code, but doing so is not required; including the original sources is sufficient. I did not find anything with unexpected licenses in the additional source. +# * Include repo tarball because the crate includes a file (device_path_gen.rs) +# generated by xtask. +Source2: https://github.com/rust-osdev/uefi-rs/archive/uefi-v%{version}/uefi-%{version}.tar.gz There is a Cargo.toml patch. Its contents are resonable and are correctly documented. +# Manually created patch for downstream crate metadata changes +# * Unpin uguid version. Upstream does this for MSRV reasons, this is not needed +# in fedora. +Patch: uefi-fix-metadata.diff The "qemu" feature is hidden for dependency reasons (no rust-qemu-exit package); ideally, there is a comment in rust2rpm.toml explaining why the feature is hidden. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/uefi-0.35.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Not a real problem; due to reasonable rust2rpm design decisions. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "*No copyright* MIT License", "*No copyright* MIT License [generated file]". 6 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2357921-rust- uefi/20250525/2357921-rust-uefi/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- uefi-devel , rust-uefi+default-devel , rust-uefi+alloc-devel , rust- uefi+global_allocator-devel , rust-uefi+log-debugcon-devel , rust- uefi+logger-devel , rust-uefi+panic_handler-devel , rust- uefi+unstable-devel [?]: Package functions as described. Tests are disabled, with adequate justification. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=133180307 [-]: %check is present and all tests pass. Tests are disabled, with adequate justification. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-uefi-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+default-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+alloc-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+global_allocator-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+log-debugcon-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+logger-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+panic_handler-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+unstable-devel-0.35.0-1.fc43.noarch.rpm rust-uefi-0.35.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp4gboc2o')] checks: 32, packages: 9 rust-uefi+alloc-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+alloc-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+default-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+default-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+global_allocator-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+global_allocator-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+log-debugcon-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+log-debugcon-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+logger-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+logger-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+panic_handler-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+panic_handler-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+unstable-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+unstable-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi.src: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi.src: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') 9 packages and 0 specfiles checked; 18 errors, 0 warnings, 49 filtered, 18 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 8 rust-uefi+global_allocator-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+global_allocator-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+log-debugcon-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+log-debugcon-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+alloc-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+alloc-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+default-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+default-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+panic_handler-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+panic_handler-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+logger-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+logger-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+unstable-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+unstable-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') 8 packages and 0 specfiles checked; 16 errors, 0 warnings, 45 filtered, 16 badness; has taken 0.2 s Source checksums ---------------- https://github.com/rust-osdev/uefi-rs/archive/uefi-v0.35.0/uefi-0.35.0.tar.gz : CHECKSUM(SHA256) this package : b8d4927aea0d32b7628b63845d0476c5c4d154a3d553ddc59efd477c76e2d493 CHECKSUM(SHA256) upstream package : b8d4927aea0d32b7628b63845d0476c5c4d154a3d553ddc59efd477c76e2d493 https://crates.io/api/v1/crates/uefi/0.35.0/download#/uefi-0.35.0.crate : CHECKSUM(SHA256) this package : da7569ceafb898907ff764629bac90ac24ba4203c38c33ef79ee88c74aa35b11 CHECKSUM(SHA256) upstream package : da7569ceafb898907ff764629bac90ac24ba4203c38c33ef79ee88c74aa35b11 Requires -------- rust-uefi-devel (rpmlib, GLIBC filtered): (crate(bitflags/default) >= 2.0.0 with crate(bitflags/default) < 3.0.0~) (crate(cfg-if/default) >= 1.0.0 with crate(cfg-if/default) < 2.0.0~) (crate(log) >= 0.4.5 with crate(log) < 0.5.0~) (crate(ptr_meta) >= 0.3.0 with crate(ptr_meta) < 0.4.0~) (crate(ptr_meta/derive) >= 0.3.0 with crate(ptr_meta/derive) < 0.4.0~) (crate(ucs2/default) >= 0.3.3 with crate(ucs2/default) < 0.4.0~) (crate(uefi-macros/default) >= 0.18.1 with crate(uefi-macros/default) < 0.19.0~) (crate(uefi-raw/default) >= 0.11.0 with crate(uefi-raw/default) < 0.12.0~) (crate(uguid/default) >= 2.2.0 with crate(uguid/default) < 3.0.0~) cargo rust rust-uefi+default-devel (rpmlib, GLIBC filtered): cargo crate(uefi) crate(uefi/log-debugcon) rust-uefi+alloc-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+global_allocator-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+log-debugcon-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+logger-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+panic_handler-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+unstable-devel (rpmlib, GLIBC filtered): cargo crate(uefi) Provides -------- rust-uefi-devel: crate(uefi) rust-uefi-devel rust-uefi+default-devel: crate(uefi/default) rust-uefi+default-devel rust-uefi+alloc-devel: crate(uefi/alloc) rust-uefi+alloc-devel rust-uefi+global_allocator-devel: crate(uefi/global_allocator) rust-uefi+global_allocator-devel rust-uefi+log-debugcon-devel: crate(uefi/log-debugcon) rust-uefi+log-debugcon-devel rust-uefi+logger-devel: crate(uefi/logger) rust-uefi+logger-devel rust-uefi+panic_handler-devel: crate(uefi/panic_handler) rust-uefi+panic_handler-devel rust-uefi+unstable-devel: crate(uefi/unstable) rust-uefi+unstable-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2357921 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: PHP, Java, Ocaml, SugarActivity, Python, Haskell, C/C++, R, fonts, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2357921 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202357921%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
