https://bugzilla.redhat.com/show_bug.cgi?id=2366921 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #4) > (In reply to Jannik Müller from comment #3) > > b) I disabled the tests, because I didnt see them as significant as this is > > a developer-only package. If you wish for that, I can re-enable them which > > would introduce some longer compile time. Switching to Fedora "ut" won't be > > a problem. > > Please enable them. It is possible to make running tests conditional to > reduce > build times, but they help check correctness during rebuilds. To back this up, https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites says: If the source code of the package provides a test suite, it should be executed in the %check section, whenever it is practical to do so. It is quite common for such test suites to usefully detect things like architecture-specific issues or incompatibilities with new compiler versions, even in header-only libraries like this one. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2366921 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202366921%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
