https://bugzilla.redhat.com/show_bug.cgi?id=2366921 --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- (In reply to Jannik Müller from comment #3) > a) Unfortunately, I can't use a system library for that. I checked and glaze > has significantly modified the header files. For dragonbox, it looks very > similar, but it would require reverting the changes. For fast_float, they > integrated and wrote around the library deeply which would require a > significant amount of work to use the system library. > Therefore, I would prefer bundling it as an exception for this case. > Ok. > b) I disabled the tests, because I didnt see them as significant as this is > a developer-only package. If you wish for that, I can re-enable them which > would introduce some longer compile time. Switching to Fedora "ut" won't be > a problem. Please enable them. It is possible to make running tests conditional to reduce build times, but they help check correctness during rebuilds. > > c) I don't think so, I will remove that. A noarch docs subpackage would be helpful. It does not seem that anything needs to be built, just adding %package doc Summary: Documentation for %{name} BuildArch: noarch %description doc Documentation and example files for %{name}. and then %files doc %license LICENSE %doc examples/ %doc docs/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2366921 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202366921%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
