https://bugzilla.redhat.com/show_bug.cgi?id=2367629 Leonardo Rossetti <lrossett@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lrossett@xxxxxxxxxx --- Comment #11 from Leonardo Rossetti <lrossett@xxxxxxxxxx> --- You could replace direct invocations of "make' and "configure" but their macro alternatives, examples: https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutorial_2_GNU_Hello/#inside_spec I see there are optional build requirements for OSS4 support, it may be a good idea to add a variable that in the spec file, something like "with_oss4" to indicate if those should be included or not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2367629 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202367629%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
