https://bugzilla.redhat.com/show_bug.cgi?id=2362051 --- Comment #8 from Fabio Valentini <decathorpe@xxxxxxxxx> --- The FIXME for 1) said to use the output of "%cargo_license_summary", which is: # (Apache-2.0 OR MIT) AND BSD-3-Clause # (MIT OR Apache-2.0) AND Unicode-DFS-2016 # 0BSD OR MIT OR Apache-2.0 # Apache-2.0 # Apache-2.0 AND ISC AND (MIT OR Apache-2.0) # Apache-2.0 OR Apache-2.0 WITH LLVM-exception # Apache-2.0 OR BSL-1.0 # Apache-2.0 OR ISC OR MIT # Apache-2.0 OR MIT # Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT # BSD-2-Clause # BSD-2-Clause OR Apache-2.0 OR MIT # BSD-3-Clause # CDLA-Permissive-2.0 # ISC # MIT # MIT OR Apache-2.0 # MIT OR Zlib OR Apache-2.0 # MIT-0 OR Apache-2.0 # MPL-2.0 # Unicode-3.0 # Unlicense OR MIT # Zlib These all need to be covered by the License tag. It currently only lists: > # src/lru_disk_cache/lru_cache.rs is Apache-2.0 OR MIT > License: Apache-2.0 OR MIT Which should be the comment and change for the License tag for the *source package* (line 15) not the *built package* (line 45), and it should be something like this instead (just "Apache-2.0 OR MIT" is wrong in this situation): > # most of sccache is Apache-2.0 except for > # src/lru_disk_cache/lru_cache.rs which is Apache-2.0 OR MIT > License: Apache-2.0 AND (Apache-2.0 OR MIT) Also, part of the patch for Cargo.toml that doesn't touch the default features now should be droppable since you no longer ship the "-devel" subpackages, but that's not a blocker, just a possible simplification for the future that can be done after the review is done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2362051 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202362051%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
