https://bugzilla.redhat.com/show_bug.cgi?id=2358954 --- Comment #16 from Cristian Le <fedora@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #14) > 0. The upstream license expression is wrong, it's "MIT OR (MIT AND > Apache-2.0)" whereas it should be "MIT AND (MIT OR Apache-2.0)". My bad, I was the one who suggested the former. Isn't it equivalent in some sense? But yeah, it would affect the concatenation I suppose. > 1. Since you exclude yaml-test-suite from the built packages, the license > tag should be just "MIT OR Apache-2.0" since no MIT-only contents end up in > the built package. This needs to be patched in Cargo.toml too so the "wrong" > expression doesn't affect the %cargo_license{,_summary} macros. Well, this is the confusion, is `license` the license of the crate or the artifacts? If it's the former, then isn't theirs as `MIT AND (MIT OR Apache-2.0)` correct, and in our case different because we don't propagate? > Alternatively, the upstream project could just exclude the yaml-test-suite stuff from published crates, that would eliminate the license expression issue entirely It would limit our ability to run those tests if they fix the `libtest-mimic` dependency issue. It does seem like a good test suite to cover, but it might be sufficient to be covered downstream only? I am not sure which way I am leaning on this one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2358954 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358954%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
