https://bugzilla.redhat.com/show_bug.cgi?id=2361600 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |berrange@xxxxxxxxxx, | |crobinso@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review? | |needinfo?(berrange@redhat.c | |om) --- Comment #4 from Cole Robinson <crobinso@xxxxxxxxxx> --- I think my original suggestion to call this `libigvm` is wrong, sorry. yeah a libigvm.a is being installed, but the .pc file is `igvm.pc` and the upstream repo is called `igvm`. So I think this package should be called `igvm`. igvm here is _only_ a static library. So the package layout is a bit interesting. With libs like glib2, pcre2, glibc you'll have package hierarchy like glib2 (or some packages call this NAME-libs) files: lib/*.so.* glib2-devel files: lib/*.so , pkgconfig, /usr/include Requires: glib2 glib2-static files: lib/*.a Requires: glib2-devel But since libigvm doesn't have .so files at all, `libigvm` doesn't exist, and `libigvm-devel` on its own is pointless. So I _think_ this should stuff pkgconfig and /usr/include bits into libigvm-static, and kill the libigvm-devel package too. If something changed and libigvm ever becomes dynamically linkable as well, the package can switch to the above ideal layout easypeasy. @berrange@xxxxxxxxxx can you sanity check me here, does all that sound reasonable? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2361600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202361600%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
