https://bugzilla.redhat.com/show_bug.cgi?id=2352900 --- Comment #10 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Benson Muite from comment #9) > a) Consider packaging some of the files in the docs directory, in particular > docs/README-versions.md > docs/README-migration.md I've added README-migration.md which seems relevant to the -devel subpackage. The README-migration.md seems a leftover document from the 2.x era, so I did not add this one. > b) Use dos2unix to prevent: > SDL3_ttf.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/SDL3_ttf/CHANGES.txt > SDL3_ttf.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/SDL3_ttf/README.md Done, also added dos2unix as a dependency. > c) Consider changing > > %{_libexecdir}/installed-tests > > to > > %dir %{_libexecdir}/installed-tests > %{_libexecdir}/installed-tests/SDL3_ttf > > to prevent accidental installation in future upgrades. Done. > e) Approved. Consider implementing non-blocking changes. Thanks for the (long) review! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2352900 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352900%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
