https://bugzilla.redhat.com/show_bug.cgi?id=2357921 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This package looks pretty good overall, but I did find a few things that need attention. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. The tests are disabled, with adequate justification: -%bcond check 1 +# * tests must be built for *-unknown-uefi target +%bcond check 0 There is a Cargo.toml patch: +# Manually created patch for downstream crate metadata changes +Patch: uefi-fix-metadata.diff It unpins uguid, which makes sense: [dependencies.uguid] -version = "=2.2.0" +version = "2.2.0" However, there should be an explanatory comment. Please note that the version pin was only for MSRV reasons, and/or cite https://github.com/rust-osdev/uefi-rs/commit/79b667f93f74f4ed97922c79cff002cc3ee85f94. You can add these comments to rust2rpm.toml: [package] cargo-toml-patch-comments = [ "Blah, blah, blah", ] Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ The rust-uefi+qemu-devel feature metapackage is not installable because it would require crate(qemu-exit/default), but we do not have a rust-qemu-exit package. If you will need to use this package with the qemu feature, you must package rust-qemu-exit; otherwise, you can patch out the qemu feature, or use features.hide in rust2rpm.toml. Either way, all subpackages need to be installable. - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/uefi-0.35.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Not a serious problem; due to reasonable rust2rpm design decisions. - Cargo.toml patch should be better-documented, as discussed above the Issues section; https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ - The file src/proto/device_path/device_path_gen.rs is generated using an xtask, the sources for which are in https://github.com/rust-osdev/uefi-rs/tree/uefi-v0.35.0/xtask/src/device_path. These sources are, in a meaningful way, the original sources for device_path_gen.rs, so they must be included in the source RPM per https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#pregenerated-code. The easiest way to do this would be to add https://github.com/rust-osdev/uefi-rs/archive/uefi-v%{version}/uefi-%{version}.tar.gz as an additional Source. Note that while you are required to include the original sources, you are not required to actually re-generate device_path_gen.rs, although it’s probably feasible if you really wanted to. For an example of using an xtask in a package build (should you choose to attempt that), see: https://src.fedoraproject.org/rpms/rust-oxipng/blob/a91b454619d4ec7e2c10baef2540e9fe200f0011/f/rust-oxipng.spec#_178 https://src.fedoraproject.org/rpms/rust-oxipng/blob/a91b454619d4ec7e2c10baef2540e9fe200f0011/f/rust-oxipng.spec#_189 https://src.fedoraproject.org/rpms/rust-oxipng/blob/a91b454619d4ec7e2c10baef2540e9fe200f0011/f/rust-oxipng.spec#_197 I think you really only need the xtask/src/device_path/ subtree of the GitHub archive, but there isn’t a way to write a URL for that, and it’s nice not to have to post-process the archive, either manually or with a script. For an example of adding a source via rust2rpm.toml, see https://src.fedoraproject.org/rpms/rust-jiff/blob/47ecebdf6dd6b495c610f3b9ec531868ae7b0ca4/f/rust2rpm.toml#_31. - The summaries exceed the 80-character limit: rust-uefi+default-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality Customize the summary in rust2rpm.toml, something like this: [package] summary = "Safe, convenient, and performant abstractions for UEFI" ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "*No copyright* MIT License", "*No copyright* MIT License [generated file]". 6 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2357921-rust- uefi/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- uefi-devel , rust-uefi+default-devel , rust-uefi+alloc-devel , rust- uefi+global_allocator-devel , rust-uefi+log-debugcon-devel , rust- uefi+logger-devel , rust-uefi+panic_handler-devel , rust-uefi+qemu- devel , rust-uefi+unstable-devel [?]: Package functions as described. Tests are disabled, with adequate justification. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. See Issues and the discussion above Issues; the patch to unpin uguid should be better-documented. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=132966971 [-]: %check is present and all tests pass. Tests are disabled, with adequate justification. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 6.1 starting (python version = 3.13.3, NVR = mock-6.1-1.fc42), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/ben/fedora/review/2357921-rust-uefi/results install /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi+unstable-devel-0.35.0-1.fc43.noarch.rpm /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi+default-devel-0.35.0-1.fc43.noarch.rpm /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi+log-debugcon-devel-0.35.0-1.fc43.noarch.rpm /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi+global_allocator-devel-0.35.0-1.fc43.noarch.rpm /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi+alloc-devel-0.35.0-1.fc43.noarch.rpm /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi+qemu-devel-0.35.0-1.fc43.noarch.rpm /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi+logger-devel-0.35.0-1.fc43.noarch.rpm /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi-devel-0.35.0-1.fc43.noarch.rpm /home/ben/fedora/review/2357921-rust-uefi/results/rust-uefi+panic_handler-devel-0.35.0-1.fc43.noarch.rpm Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Mock Version: 6.1 INFO: Mock Version: 6.1 Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: Package manager dnf5 detected and used (fallback) Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin INFO: Package manager dnf5 detected and used (direct choice) Finish: chroot init INFO: installing package(s): /builddir/rust-uefi+unstable-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+default-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+log-debugcon-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+global_allocator-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+alloc-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+qemu-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+logger-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+panic_handler-devel-0.35.0-1.fc43.noarch.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 9d59378320ed48498819f17ac0d7a8f5 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.q_99ataz:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 43 install /builddir/rust-uefi+unstable-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+default-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+log-debugcon-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+global_allocator-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+alloc-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+qemu-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+logger-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi-devel-0.35.0-1.fc43.noarch.rpm /builddir/rust-uefi+panic_handler-devel-0.35.0-1.fc43.noarch.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts Rpmlint ------- Checking: rust-uefi-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+default-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+alloc-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+global_allocator-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+log-debugcon-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+logger-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+panic_handler-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+qemu-devel-0.35.0-1.fc43.noarch.rpm rust-uefi+unstable-devel-0.35.0-1.fc43.noarch.rpm rust-uefi-0.35.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpaxkek064')] checks: 32, packages: 10 rust-uefi+alloc-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi+default-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi+global_allocator-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi+log-debugcon-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi+logger-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi+panic_handler-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi+qemu-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi+unstable-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi.src: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi-devel.noarch: E: summary-too-long Makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality rust-uefi+alloc-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+alloc-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+default-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+default-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+global_allocator-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+global_allocator-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+log-debugcon-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+log-debugcon-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+logger-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+logger-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+panic_handler-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+panic_handler-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+qemu-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+qemu-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi+unstable-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi+unstable-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi.src: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi.src: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') rust-uefi-devel.noarch: E: spelling-error ('performant', 'Summary(en_US) performant -> perform ant, perform-ant, performance') rust-uefi-devel.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance') 10 packages and 0 specfiles checked; 30 errors, 0 warnings, 55 filtered, 30 badness; has taken 0.6 s Source checksums ---------------- https://crates.io/api/v1/crates/uefi/0.35.0/download#/uefi-0.35.0.crate : CHECKSUM(SHA256) this package : da7569ceafb898907ff764629bac90ac24ba4203c38c33ef79ee88c74aa35b11 CHECKSUM(SHA256) upstream package : da7569ceafb898907ff764629bac90ac24ba4203c38c33ef79ee88c74aa35b11 Requires -------- rust-uefi-devel (rpmlib, GLIBC filtered): (crate(bitflags/default) >= 2.0.0 with crate(bitflags/default) < 3.0.0~) (crate(cfg-if/default) >= 1.0.0 with crate(cfg-if/default) < 2.0.0~) (crate(log) >= 0.4.5 with crate(log) < 0.5.0~) (crate(ptr_meta) >= 0.3.0 with crate(ptr_meta) < 0.4.0~) (crate(ptr_meta/derive) >= 0.3.0 with crate(ptr_meta/derive) < 0.4.0~) (crate(ucs2/default) >= 0.3.3 with crate(ucs2/default) < 0.4.0~) (crate(uefi-macros/default) >= 0.18.1 with crate(uefi-macros/default) < 0.19.0~) (crate(uefi-raw/default) >= 0.11.0 with crate(uefi-raw/default) < 0.12.0~) (crate(uguid/default) >= 2.2.0 with crate(uguid/default) < 3.0.0~) cargo rust rust-uefi+default-devel (rpmlib, GLIBC filtered): cargo crate(uefi) crate(uefi/log-debugcon) rust-uefi+alloc-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+global_allocator-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+log-debugcon-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+logger-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+panic_handler-devel (rpmlib, GLIBC filtered): cargo crate(uefi) rust-uefi+qemu-devel (rpmlib, GLIBC filtered): (crate(qemu-exit/default) >= 3.0.2 with crate(qemu-exit/default) < 4.0.0~) cargo crate(uefi) crate(uefi/log-debugcon) crate(uefi/panic_handler) rust-uefi+unstable-devel (rpmlib, GLIBC filtered): cargo crate(uefi) Provides -------- rust-uefi-devel: crate(uefi) rust-uefi-devel rust-uefi+default-devel: crate(uefi/default) rust-uefi+default-devel rust-uefi+alloc-devel: crate(uefi/alloc) rust-uefi+alloc-devel rust-uefi+global_allocator-devel: crate(uefi/global_allocator) rust-uefi+global_allocator-devel rust-uefi+log-debugcon-devel: crate(uefi/log-debugcon) rust-uefi+log-debugcon-devel rust-uefi+logger-devel: crate(uefi/logger) rust-uefi+logger-devel rust-uefi+panic_handler-devel: crate(uefi/panic_handler) rust-uefi+panic_handler-devel rust-uefi+qemu-devel: crate(uefi/qemu) rust-uefi+qemu-devel rust-uefi+unstable-devel: crate(uefi/unstable) rust-uefi+unstable-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2357921 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Python, Perl, R, PHP, fonts, Ocaml, Haskell, SugarActivity, Java, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2357921 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202357921%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
