[Bug 2336907] Review Request: zmusic - GZDoom's music system as a standalone library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2336907



--- Comment #8 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---

Thanks Srisharan for the informal review.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: zmusic-headers : /usr/include/zmusic.h
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages


This is a false positive as it appears to be a common package. As it is
not used on its own, perhaps give it the name zmusic-common-devel

===== MUST items =====

C/C++:
[c]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "*No copyright*
     GNU General Public License, Version 3 and/or GNU Lesser General Public
     License, Version 3", "GNU Lesser General Public License, Version 2.1",
     "GNU Lesser General Public License, Version 3", "*No copyright* GNU
     General Public License, Version 3 and/or GNU Lesser General Public
     License, Version 2.1", "GNU General Public License v2.0 or later",
     "GNU Library General Public License v2 or later [obsolete FSF postal
     address (Temple Place)]", "GNU General Public License v3.0 or later",
     "MIT License", "Public domain", "*No copyright* Public domain", "*No
     copyright* GNU Lesser General Public License", "GNU Lesser General
     Public License v2.1 or later", "GNU General Public License, Version
     2", "GNU Lesser General Public License v2.1 or later [obsolete FSF
     postal address (Temple Place)]", "GNU General Public License v2.0 or
     later [obsolete FSF postal address (Temple Place)]", "GNU General
     Public License and/or GNU Lesser General Public License, Version 3",
     "Boost Software License 1.0", "*No copyright* MIT License", "*No
     copyright* GNU General Public License, Version 2", "BSD 2-Clause
     License". 274 files have unknown license. Detailed output of
     licensecheck in /home/fedora-packaging/reviews/zmusic/2336907-
     zmusic/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/cmake/ZMusic
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/cmake/ZMusic
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Macros in Summary, %description expandable at SRPM build time.
     Note: Macros in: zmusic-headers (description)
[-]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zmusic-
     lite , zmusic-lite-devel , zmusic-headers
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: zmusic-1.1.14-1.fc43.x86_64.rpm
          zmusic-lite-1.1.14-1.fc43.x86_64.rpm
          zmusic-devel-1.1.14-1.fc43.x86_64.rpm
          zmusic-lite-devel-1.1.14-1.fc43.x86_64.rpm
          zmusic-headers-1.1.14-1.fc43.x86_64.rpm
          zmusic-1.1.14-1.fc43.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_q2bg6bm')]
checks: 32, packages: 6

zmusic.spec:43: W: unversioned-explicit-provides bundled(oplsynth)
zmusic.spec:47: W: unversioned-explicit-provides bundled(timidity)
zmusic.spec:49: W: unversioned-explicit-provides bundled(timidity++)
zmusic.spec:51: W: unversioned-explicit-provides bundled(wildmidi)
zmusic-headers.x86_64: W: unexpanded-macro %description -l C %{name
zmusic-headers.x86_64: W: only-non-binary-in-usr-lib
zmusic.x86_64: W: no-documentation
zmusic-devel.x86_64: W: no-documentation
zmusic-headers.x86_64: W: no-documentation
zmusic-lite.x86_64: W: no-documentation
zmusic-lite-devel.x86_64: W: no-documentation
zmusic.spec:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 11)
 6 packages and 0 specfiles checked; 0 errors, 12 warnings, 45 filtered, 0
badness; has taken 0.8 s 




Rpmlint (debuginfo)
-------------------
Checking: zmusic-debuginfo-1.1.14-1.fc43.x86_64.rpm
          zmusic-lite-debuginfo-1.1.14-1.fc43.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_se6dbl0')]
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 16 filtered, 0
badness; has taken 0.8 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 7

zmusic-headers.x86_64: W: unexpanded-macro %description -l C %{name
zmusic-headers.x86_64: W: only-non-binary-in-usr-lib
zmusic-lite.x86_64: W: no-documentation
zmusic.x86_64: W: no-documentation
zmusic-headers.x86_64: W: no-documentation
zmusic-lite-devel.x86_64: W: no-documentation
zmusic-devel.x86_64: W: no-documentation
zmusic-lite.x86_64: E: incorrect-fsf-address
/usr/share/licenses/zmusic-lite/lgplv21.txt
zmusic.x86_64: E: incorrect-fsf-address /usr/share/licenses/zmusic/lgplv21.txt
 7 packages and 0 specfiles checked; 2 errors, 7 warnings, 59 filtered, 2
badness; has taken 1.0 s 



Source checksums
----------------
https://github.com/ZDoom/ZMusic/archive/refs/tags/1.1.14.tar.gz :
  CHECKSUM(SHA256) this package     :
f04410fe4ea08136f37703e7715c27df4c8532ace1e721cf40c6f303a93acc54
  CHECKSUM(SHA256) upstream package :
f04410fe4ea08136f37703e7715c27df4c8532ace1e721cf40c6f303a93acc54


Requires
--------
zmusic (rpmlib, GLIBC filtered):
    libasound.so.2()(64bit)
    libasound.so.2(ALSA_0.9)(64bit)
    libc.so.6()(64bit)
    libfluidsynth.so.3()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libmpg123.so.0()(64bit)
    libsndfile.so.1()(64bit)
    libsndfile.so.1(libsndfile.so.1.0)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libxmp.so.4()(64bit)
    libxmp.so.4(XMP_4.0)(64bit)
    libxmp.so.4(XMP_4.1)(64bit)
    libxmp.so.4(XMP_4.4)(64bit)
    libxmp.so.4(XMP_4.5)(64bit)
    rtld(GNU_HASH)

zmusic-lite (rpmlib, GLIBC filtered):
    libasound.so.2()(64bit)
    libasound.so.2(ALSA_0.9)(64bit)
    libc.so.6()(64bit)
    libfluidsynth.so.3()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libmpg123.so.0()(64bit)
    libsndfile.so.1()(64bit)
    libsndfile.so.1(libsndfile.so.1.0)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libxmp.so.4()(64bit)
    libxmp.so.4(XMP_4.0)(64bit)
    libxmp.so.4(XMP_4.1)(64bit)
    libxmp.so.4(XMP_4.4)(64bit)
    libxmp.so.4(XMP_4.5)(64bit)
    rtld(GNU_HASH)

zmusic-devel (rpmlib, GLIBC filtered):
    libzmusic.so.1()(64bit)
    zmusic(x86-64)
    zmusic-headers

zmusic-lite-devel (rpmlib, GLIBC filtered):
    libzmusiclite.so.1()(64bit)
    zmusic-headers
    zmusic-lite(x86-64)

zmusic-headers (rpmlib, GLIBC filtered):
    (zmusic-devel(x86-64) = 1.1.14-1.fc43 or zmusic-lite-devel(x86-64) =
1.1.14-1.fc43)
    cmake-filesystem(x86-64)



Provides
--------
zmusic:
    bundled(adlmidi)
    bundled(dumb)
    bundled(game-music-emu)
    bundled(miniz)
    bundled(oplsynth)
    bundled(opnmidi)
    bundled(timidity)
    bundled(timidity++)
    bundled(wildmidi)
    libzmusic.so.1()(64bit)
    zmusic
    zmusic(x86-64)

zmusic-lite:
    libzmusiclite.so.1()(64bit)
    zmusic-lite
    zmusic-lite(x86-64)

zmusic-devel:
    zmusic-devel
    zmusic-devel(x86-64)

zmusic-lite-devel:
    zmusic-lite-devel
    zmusic-lite-devel(x86-64)

zmusic-headers:
    cmake(ZMusic)
    cmake(zmusic)
    zmusic-headers
    zmusic-headers(x86-64)



Diff spec file in url and in SRPM
---------------------------------
--- /home/fedora-packaging/reviews/zmusic/2336907-zmusic/srpm/zmusic.spec      
2025-05-17 18:54:33.259841716 +0300
+++
/home/fedora-packaging/reviews/zmusic/2336907-zmusic/srpm-unpacked/zmusic.spec 
    2025-03-08 03:00:00.000000000 +0300
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.7.3)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 Name:          zmusic
 Version:       1.1.14
@@ -127,3 +137,6 @@

 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Sat Mar 08 2025 John Doe <packager@xxxxxxxxxxx> - 1.1.14-1
+- Uncommitted changes
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2336907
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: fonts, Ocaml, Python, R, SugarActivity, Java, Haskell, Perl,
PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Can dumb and opnmidi be packaged separately?

b) Please add
%dir %{_libdir}/cmake/ZMusic/
to the spec file

c) Please change
Source0:        %{url}/archive/refs/tags/%{version}.tar.gz
to
Source0:        %{url}/archive/%{version}/zmusic-%{version}.tar.gz
d) License listing:

includes:

Boost Software License 1.0
--------------------------
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/adlmidi/structures/pl_list.hpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/adlmidi/structures/pl_list.tcc
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/structures/pl_list.hpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/structures/pl_list.tcc


GNU General Public License v2.0 or later
----------------------------------------
zmusic-1.1.14-build/ZMusic-1.1.14/source/mididevices/driver_adlib.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/adlmidi/chips/dosbox/dbopl.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/adlmidi/chips/dosbox/dbopl.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/gens/Ym2612.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/gens/Ym2612.hpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/gens/Ym2612_p.hpp

GNU General Public License v2.0 or later [obsolete FSF postal address (Temple
Place)]
-------------------------------------------------------------------------------------
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/common.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/configfile.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/effect.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/filter.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/freq.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/instrum.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/mblock.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/mix.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/playmidi.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/quantity.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/readmidic.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/recache.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/resample.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/reverb.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/sbkconv.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/sffile.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/sfitem.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/smplfile.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/sndfont.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/tables.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/common.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/controls.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/filter.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/freq.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/instrum.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/mblock.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/mix.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/optcode.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/playmidi.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/quantity.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/recache.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/resample.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/reverb.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/sffile.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/sfitem.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/sflayer.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/sysdep.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/tables.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/timidityplus/timiditypp/timidity.h

GNU General Public License, Version 2
-------------------------------------
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/oplsynth/fmopl.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/mamefm/fm.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/mamefm/fm.h
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/mamefm/ymdeltat.cpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/mamefm/ymdeltat.h

Public domain
-------------
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/adlmidi/fraction.hpp
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/fraction.hpp

BSD 2-Clause License
--------------------
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/pmdwin/LICENSE
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/pmdwin/opna.c
zmusic-1.1.14-build/ZMusic-1.1.14/thirdparty/opnmidi/chips/pmdwin/psg.c

These seem to be missing from the license declarations.
c) Consider putting
the files

ZMusicFullTargets.cmake
ZMusicFullTargets-debug.cmake

in the main devel package and the files

ZMusicLiteTargets.cmake
ZMusicLiteTargets-debug.cmake

in the lite-devel package.

d) Consider raising an issue upstream to use the laest text for the GNU
licenses.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2336907

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202336907%23c8

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux