https://bugzilla.redhat.com/show_bug.cgi?id=2352900 --- Comment #7 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Benson Muite from comment #4) > a) Please list contents of %{_bindir}, they should not be globbed as would > not want to > have conflicts when doing an upgrade. > The binaries are glfont, showfont, testapp and testgputext which have > generic names > In particular testapp is also provided by > golang-github-nbutton23-zxcvbn-0:0.1-16.20210110gite56b841.fc41.x86_64 > zimg-devel-0:3.0.5-3.fc41.i686 > zimg-devel-0:3.0.5-3.fc41.x86_64 Thank you very much for https://github.com/libsdl-org/SDL_ttf/issues/546! I backported the official commit that moves all the test binaries in /usr/libexec/insalled-tests. This means the samples subpackage has been dropped, and the files are just part of -devel. Regarding the globbing, no single package owns /usr/libexec/insalled-tests, and every package shipping stuff inside there it's owning directly the directory /usr/libexec/insalled-tests and downwards, so I did the same. > b) > https://github.com/libsdl-org/SDL_ttf/blob/main/docs/hello.c > https://github.com/libsdl-org/SDL_ttf/blob/main/examples/editbox.c > https://github.com/libsdl-org/SDL_ttf/blob/main/examples/editbox.h > > are under a different license That example is not packaged, so we don't need to declare the license. Anyway it should be covered by MIT, as per the SDL3_image review. > c) Perhaps a smoke test can be added: > https://github.com/libsdl-org/SDL_ttf/blob/main/.github/workflows/main. > yml#L114-L117 Done. > d) Please package latest release 3.2.2 Done. Spec URL: https://slaanesh.fedorapeople.org/review/SDL3_ttf.spec SRPM URL: https://slaanesh.fedorapeople.org/review/SDL3_ttf-3.2.2-1.fc42.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2352900 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352900%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
