[Bug 2366587] Review Request: ipv6toolkit - Security assessment and troubleshooting tools for IPv6 protocols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2366587



--- Comment #6 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> ---
Spec URL: https://labs.linuxnetz.de/bugzilla/ipv6toolkit.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/ipv6toolkit-2.2-2.src.rpm


1. License tag has been corrected and a breakdown is in the spec file, too.
However, there is no "RealNetworks Public Source License" involved, the license
check somehow gets (wrongly) triggered by the word "real" in the man page.


2. The missing-call-to-setgroups-before-setuid error is a detection mistake in
rpmlint:

$ grep -r -E set[ug]id ipv6toolkit-2.2
ipv6toolkit-2.2/tools/libipv6.c:       If the real UID is not root, we setuid()
and setgid() to that user and group, releasing superuser
ipv6toolkit-2.2/tools/libipv6.c:       privileges. Otherwise, if the real UID
is 0, we try to setuid() to "nobody", releasing superuser
ipv6toolkit-2.2/tools/libipv6.c:        if (setgid(rgid) == -1) {
ipv6toolkit-2.2/tools/libipv6.c:        if (setuid(ruid) == -1) {
ipv6toolkit-2.2/tools/libipv6.c:            if (setgid(pwdptr->pw_gid) == -1) {
ipv6toolkit-2.2/tools/libipv6.c:            if (setuid(pwdptr->pw_uid) == -1) {
$ 

See also:
https://github.com/fgont/ipv6toolkit/blob/master/tools/libipv6.c#L1841


[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux