https://bugzilla.redhat.com/show_bug.cgi?id=2363087 --- Comment #11 from Elaine Gibson <ypsvlq@xxxxxxxxx> --- (In reply to Alex Haydock from comment #9) > 1. Patch0 and Patch1 should have a justification provided in a comment to > explain why they're being brought in from upstream. Fair, I didn't comment them as the links go to directly to upstream commits, but it would be clearer. > 2. There is no documentation installed although an empty docdir does get > created. I took a look through the upstream repo and couldn't find any > manpages but this should be verified just in case. > > fooyin.x86_64: W: no-manual-page-for-binary fooyin > fooyin-devel.x86_64: W: no-documentation The README is installed as documentation (and packaged), there is no man page or devel-specific documentation though. > 3. Is it accurate that the package has no runtime deps other than the icon > theme? I cross-referenced the BuildRequires with the build instructions from > upstream but wasn't able to test all features of the app to validate. RPM infers the library dependencies (see the Requires in the review template). hicolor-icon-theme owns /usr/share/icons/hicolor and is required explicitly per https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership > I'll paste the full review output in the next comment. Hopefully this helps! Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2363087 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363087%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
