https://bugzilla.redhat.com/show_bug.cgi?id=2363087 Alex Haydock <alex@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex@xxxxxxxxxxxxxxxxx --- Comment #9 from Alex Haydock <alex@xxxxxxxxxxxxxxxxx> --- Hi! I'm new to Fedora packaging and looking to learn more about the process before getting sponsorship to bring my own packages into Fedora. I took a look at this one as a non-binding review to help. I'm not able to sponsor packages yet, but hopefully this is helpful. I went through the checklist. There aren't too many things that stood out to me. The main highlights: 1. Patch0 and Patch1 should have a justification provided in a comment to explain why they're being brought in from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. 2. There is no documentation installed although an empty docdir does get created. I took a look through the upstream repo and couldn't find any manpages but this should be verified just in case. fooyin.x86_64: W: no-manual-page-for-binary fooyin fooyin-devel.x86_64: W: no-documentation 3. Is it accurate that the package has no runtime deps other than the icon theme? I cross-referenced the BuildRequires with the build instructions from upstream but wasn't able to test all features of the app to validate. [?]: Final provides and requires are sane (see attachments). I'll paste the full review output in the next comment. Hopefully this helps! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2363087 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363087%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
