https://bugzilla.redhat.com/show_bug.cgi?id=2365763 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@xxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |mikel@xxxxxxxxxxxxxxx Status|NEW |ASSIGNED --- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > %global common_description %{expand: > Terminal file manager.} Description should be a bit more... descriptive. > %generate_buildrequires > %go_generate_buildrequires Go-SIG will propose to make vendored builds the default option using go-vendor-tools for Fedora 43. lf's dependency stack is small, but I would recommend to adopt the new format to make things simpler for you. You can generate the new spec with `go2rpm -p vendor github.com/gokcehan/lf` and you can check examples like helm or opentofu packages to see how it works. I would recommend to join Go-SIG's Matrix channel for more guidance if required: https://matrix.to/#/#golang:fedoraproject.org If you prefer to keep the old method I can review the dependency as well. > install -m 0644 -Dvp etc/%{name}.zsh %{buildroot}%{_datadir}/zsh/site-functions/_%{name} > install -m 0644 -Dvp etc/%{name}.fish %{buildroot}%{_datadir}/fish/vendor_completions.d/%{name}.fish You can use %{fish_completions_dir}/%{name}.fish and %{zsh_completions_dir}/_%{name} as you do with %{bash_completions_dir} -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2365763 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202365763%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
