https://bugzilla.redhat.com/show_bug.cgi?id=2365475 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #3) > Package looks good to me, two minor things: > > - The /test-build.sh file causes a dependency on /bin/bash to get generated, > please exclude it from the built package. Fixing and preparing an updated submission, thanks. > - The "config" dependency is used for one single test file > (tests/managed_config.rs), it could be dropped entirely if that test file is > dropped too - but that's up to you. The current patch is OK too, of course. Hmm. It turns out that the test file in question starts with #![cfg(all(feature = "managed", feature = "serde"))] and serde is not a default feature, so the test isn’t even being run. I can therefore drop the config dev-dependency without even having to remove the test file or patch out the reference to it in Cargo.toml. I’ll do that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2365475 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202365475%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
